Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit adds validation checks for BOLT 12 invoices in the LND Lightning node software. It ensures invoices contain required fields (creation time, amount, payment hash, node ID, payment paths), match their originating invoice requests…
New validation gate added to Invoice.Encode() to reject malformed invoices before serializationReader rejects unknown even invoice TLV types and unknown even feature bitsReader enforces chain compatibility against activeChain
This commit is a hardening and cleanup of a GitHub Actions workflow that automatically labels pull requests by severity. It does not change any LND node code, wallet logic, or network protocol. Instead, it splits the workflow into two jobs…
Principle of least privilege: write token moved out of the model-bearing jobUntrusted input (model-generated comment) sanitized before privileged API useExternal action pinned to immutable commit SHA instead of mutable tag
This commit adds a new RPC called SubmitPackage to LND's WalletKit. It lets users submit a group of related Bitcoin transactions together so a zero-fee parent can be accepted because a later child transaction pays its fee. This is a featur…
New RPC endpoint gated by onchain:write macaroon permissionPackage size bounded to 25 transactions to limit deserialization workFee-rate ceiling passed through to backend; explicit 0 disables limit
This commit adds validation checks for BOLT 12 invoice requests in the LND Lightning node. It ensures that invoice requests follow protocol rules when being created (written) and received (read), rejecting malformed or non-compliant reques…
New input validation functions added for protocol messagesValidation now runs before encoding, preventing malformed outbound messagesOverflow guard added for amount*quantity calculation
This is a large dependency upgrade for the LND Lightning node software. It moves LND from older btcd Bitcoin library packages to new 'v2' packages and updates related wallet and network libraries. The commit is almost entirely mechanical i…
Large dependency upgrade touching core Bitcoin primitives (wire, txscript, chainhash, btcutil, psbt, address)Migration to new v2 module layout with API changes in address handlingPins new upstream releases (btcd 0.26.0, btcwallet 0.17.0, neutrino 0.18.0, lightning-onion 1.4.0) that may include undisclosed fixes
This commit fixes a bug in LND's DNS seed bootstrap code that could crash the node. The code assumed every record in a DNS response was an SRV record, so a non-SRV record (like a normal A or CNAME record) would cause a panic. The fix safel…
Unconditional type assertion panic in DNS fallback pathMissing bounds check on LookupHost result before array indexingMissing network deadline on manually dialed DNS TCP connection
This commit removes a temporary security workaround in a Go module file. The workaround forced the use of a newer, fixed version of a compression library (xz) to avoid a known historical vulnerability. The commit message says the library i…
Removal of a dependency-level vulnerability workaroundReference to historical advisory GHSA-25xm-hr59-7c27 in deleted commentNo code changes; only go.mod cleanup
This commit removes an old workaround in LND's dependency file (go.mod) that pinned a safe version of the 'xz' compression library. The workaround was originally added because another dependency once pulled in a vulnerable version of xz. T…
Removal of a dependency override that was a security mitigation for CVE-2021-29482Commit explicitly references the original GHSA advisory (GHSA-25xm-hr59-7c27)No actual downgrade or re-introduction of the vulnerable module is visible in the diff
This commit is a cleanup-only change that removes unnecessary loop-variable copies in Go test files. Since Go 1.22, loop variables are already scoped per-iteration, so the old `x := x` workarounds are redundant. The change affects only tes…
This commit updates a dependency version in LND's build files. It bumps the internal 'kvdb' submodule from version 1.5.0 to 1.5.1 so that downstream projects importing kvdb directly do not pull in an older, vulnerable telemetry library (Op…
Dependency bump explicitly motivated by a known vulnerability identifier (GO-2026-4394)No source code changes in LND itself; only module metadata updatedVendor describes the root build as already unaffected, limiting direct security impact on LND
This commit removes support for obsolete Tor v2 onion addresses from the Lightning Network Daemon (lnd). Tor v2 services were shut down by the Tor network in October 2021, so lnd will no longer create, accept, or dial v2 onion addresses. H…
Removal of deprecated network protocol (Tor v2) reduces attack surface and prevents futile/unsafe dials to unreachable services.Input validation added at operator boundaries (ParseAddressString, parseAddr) to reject v2 .onion addresses with a clear error.On-disk legacy key fallback now validates decrypted key type and rejects non-v3 (RSA1024) keys before passing them to Tor.
This commit fixes a bug in LND's remote-signing setup where zero-value previous transaction outputs were wrongly ignored when preparing a PSBT for a remote signer. The most concrete affected use case is BIP-322 message attestation, where t…
Functional denial-of-service in remote-signer BIP-322 workflows due to PSBT rejectionIncorrect zero-value UTXO validation caused legitimate outputs to be droppedFix removes Value check while preserving non-empty PkScript sanity check
This commit only adds new unit tests for an existing helper function in LND's RPC wallet code. It does not change any production logic, so it cannot introduce a security vulnerability or directly fix one in the code being committed. The te…
This commit removes old, unused code paths for sending Lightning payments through the main RPC server. These RPCs (SendPayment, SendPaymentSync, SendToRoute, SendToRouteSync) were already deleted from the service definition in a prior chan…
Removal of deprecated RPC handlers and macaroon permissionsDeletion of dead payment-dispatch helper codeNo new input parsing, network exposure, or privilege changes introduced
This commit removes three old, deprecated payment RPC methods (SendPayment, SendToRoute, and TrackPayment) from the LND Lightning node's router service. These methods were already replaced by newer V2 versions and were only thin wrappers a…
Removal of deprecated RPC surface reduces attack surfaceMacaroon permission entries for removed methods are deletedNo new code paths or logic added
This change closes a denial-of-service weakness in LND's onion-message forwarding. Previously, an attacker could create unlimited free peer identities and burn through the global byte-budget reserved for onion messages, starving real peers…
Adds a Sybil-resistance gate requiring funded, non-pending channels for onion message ingressChannel gate runs before per-peer and global rate limiters, preventing no-channel peers from consuming any token budgetIntroduces atomic shadow counter for O(1) hot-path checks on every incoming onion packet
This commit only updates test data in a JSON file used for automated tests of Lightning's new taproot channel features. It adds secret nonce values and corrects public nonce values so the test vectors match the expected commitment transact…
No production code modifiedTest-only JSON fixture updateNonce values are part of test vectors, not live secrets
This change adds a hidden switch that lets developers plug in a custom random source when creating MuSig2 signing nonces, mainly so tests can produce exactly the same signatures every time. In normal operation the switch is left empty, so …
New optional custom random source for MuSig2 nonce generationDefault call sites explicitly pass empty option, preserving CSPRNG behaviorCode comments state the option is intended only for reproducible test vectors
This commit only adds new test code and a JSON file of expected test outputs for Taproot Lightning channels. It does not change any production logic, network behavior, or wallet handling. There is no security issue in the commit itself.
This commit only adds a new test to the project's test suite. It does not change any production code, user-facing behavior, or network protocol. The new test cryptographically checks that example transactions in the project's test data car…
Adds independent cryptographic signature verification for test vectorsUses txscript.NewEngine with StandardVerifyFlags to mirror on-chain validationVerifies both the commitment transaction and each HTLC resolution transaction
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
AI review queuedlnwallet: use channel state open channelby ziggie · fa31c564 · Jul 7, 2026 · 9 filesMessage 78 · AdequateTriage 12Details
Commit message · ziggie
lnwallet: use channel state open channel
Update lnwallet channel, reservation, wallet, and test helpers to use chanstate.OpenChannel directly.
The wallet package still imports channeldb for database APIs and other channel-state aliases, but the OpenChannel type boundary now points at the package that owns the type.
78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
Lower-prioritypeer: use channel state open channelby ziggie · a459bc46 · Jul 7, 2026 · 3 filesMessage 78 · AdequateTriage 0Details
Commit message · ziggie
peer: use channel state open channel
Update peer channel loading, validation, and test helpers to use chanstate.OpenChannel directly.
The peer package still depends on channeldb for store-level errors and helpers, but no longer needs the OpenChannel alias in its public channel-state boundary.
78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI review queuedhtlcswitch: use channel state open channelby ziggie · a4bec71b · Jul 7, 2026 · 1 fileMessage 78 · AdequateTriage 0Details
Commit message · ziggie
htlcswitch: use channel state open channel
Update htlcswitch test utilities to construct and pass chanstate.OpenChannel values directly.
This removes another test-only dependency on the channeldb OpenChannel alias while leaving the test database helpers unchanged.
78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
Lower-priorityrpcserver: use channel state open channelby ziggie · 4a34503c · Jul 7, 2026 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · ziggie
rpcserver: use channel state open channel
Update RPC helpers that format open channel data to accept chanstate.OpenChannel directly.
These helpers only inspect channel state and do not need to name the channeldb OpenChannel alias.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritychanstate: use channel types in local chansby ziggie · a546c759 · Jul 7, 2026 · 2 filesMessage 68 · AdequateTriage 0Details
Commit message · ziggie
chanstate: use channel types in local chans
Move the local channel manager fetch boundary to chanstate types.
The manager still imports channeldb for the concrete not-found error, but channel state values and config constraints now use the chanstate package directly.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritychanstate: use channel type in gossiperby ziggie · 7bd24477 · Jul 7, 2026 · 2 filesMessage 68 · AdequateTriage 0Details
Commit message · ziggie
chanstate: use channel type in gossiper
Move the gossiper channel lookup callback to chanstate.OpenChannel.
Discovery still depends on channeldb for waiting-proof persistence. This commit only removes the channeldb compatibility alias from the channel state lookup boundary.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritychanstate: use channel types in link configby ziggie · da94a411 · Jul 7, 2026 · 4 filesMessage 68 · AdequateTriage 0Details
Commit message · ziggie
chanstate: use channel types in link config
Move htlcswitch link-facing channel state boundaries to chanstate.
The link still uses channeldb for forwarding-package persistence, but channel update callbacks, tower registration, and dust helper channel types now use the channel state package directly.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Security candidatefunding: use channel state open channelby ziggie · 03daaad4 · Jul 7, 2026 · 2 filesMessage 68 · AdequateTriage 18Details
Commit message · ziggie
funding: use channel state open channel
Update the funding manager callback and helper signatures to depend on the chanstate OpenChannel type instead of the channeldb alias.
The funding manager already receives channel persistence through the chanstate Store interface, so this keeps its open-channel boundary aligned with the backend-independent package.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundary
AI review queuedserver: use channel state open channelby ziggie · 8e709678 · Jul 7, 2026 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · ziggie
server: use channel state open channel
Update server callback wiring to use chanstate.OpenChannel at the funding manager boundary.
This follows the funding package change and removes another consumer-facing dependency on the channeldb OpenChannel alias.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
Lower-prioritychanstate: use channel types in watchtowerby ziggie · 4bb78770 · Jul 7, 2026 · 5 filesMessage 68 · AdequateTriage 0Details
Commit message · ziggie
chanstate: use channel types in watchtower
Move watchtower blob and client channel-type boundaries to chanstate.
The wtclient manager still imports channeldb for closed-channel lookup errors, but the channel type and close-summary payloads now use the channel state package directly.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritychanstate: use channel type in lnpeerby ziggie · c58d51d5 · Jul 7, 2026 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · ziggie
chanstate: use channel type in lnpeer
Move lnpeer.NewChannel to embed chanstate.OpenChannel.
This keeps the peer-facing channel event type independent of the channeldb compatibility alias while preserving the existing embedded OpenChannel field shape for callers.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritychanstate: use channel types in backupsby ziggie · dac8a8fe · Jul 7, 2026 · 5 filesMessage 68 · AdequateTriage 0Details
Commit message · ziggie
chanstate: use channel types in backups
Move static channel backup construction to chanstate channel types.
The package still imports channeldb where it uses real database concerns, including address sourcing and duplicate-channel recovery. The backup payload and live-channel source boundaries no longer depend on the channeldb compatibility aliases.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI review queuedchanstate: use channel type in wallet rpcby ziggie · 8a215d9e · Jul 7, 2026 · 1 fileMessage 68 · AdequateTriage 12Details
Commit message · ziggie
chanstate: use channel type in wallet rpc
Move the waiting-close channel helper to chanstate.OpenChannel.
The helper consumes channel state returned by the store interface, so it should not spell the channeldb compatibility alias. Other database errors and APIs in the wallet RPC server remain on channeldb.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
Move the htlcswitch channel fetch callbacks to chanstate types.
The switch still depends on channeldb for its KV circuit storage and forwarding package access. This commit only moves channel-state payloads at the switch and circuit-map boundaries.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritychanstate: use channel type in backup notifierby ziggie · 897f2ce5 · Jul 7, 2026 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · ziggie
chanstate: use channel type in backup notifier
Move the root backup notifier adapter to chanstate.OpenChannel.
The adapter still depends on channeldb for address sourcing and close type handling, but the new-channel payload it forwards into chanbackup now matches the chanstate-owned backup interfaces.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritychanstate: use channel type in status managerby ziggie · cd038345 · Jul 7, 2026 · 2 filesMessage 68 · AdequateTriage 0Details
Commit message · ziggie
chanstate: use channel type in status manager
Move the channel status manager working set to chanstate.OpenChannel.
The DB interface already returns channelstate channel values, so this removes another channeldb compatibility alias from the consumer path while keeping the graph and announcement behavior unchanged.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritychanstate: use channel types in consumersby ziggie · fea9c171 · Jul 7, 2026 · 4 filesMessage 68 · AdequateTriage 0Details
Commit message · ziggie
chanstate: use channel types in consumers
Move channelnotifier and invoice hop-hint code to the chanstate channel types.
These consumers already depend on the chanstate store interfaces, so they no longer need to refer to the channeldb compatibility aliases for OpenChannel and ChannelCloseSummary.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritychanstate: use channel types in interfacesby ziggie · a3fdcba5 · Jul 7, 2026 · 3 filesMessage 68 · AdequateTriage 0Details
Commit message · ziggie
chanstate: use channel types in interfaces
Move small interface-only consumers to chanstate.OpenChannel.
These packages only expose open-channel values through callback or store interfaces, so they can depend on the channel-state package without pulling in channeldb compatibility aliases.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritychanstate: use channel types in fitnessby ziggie · 19e656b2 · Jul 7, 2026 · 3 filesMessage 68 · AdequateTriage 0Details
Commit message · ziggie
chanstate: use channel types in fitness
Move channel event payloads in chanfitness to chanstate types.
The event store still uses channeldb for flap-count persistence and related errors, but open-channel and close-summary values now come from the channel-state package.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritychanstate: use htlc type in beaconby ziggie · 471c9b69 · Jul 7, 2026 · 2 filesMessage 68 · AdequateTriage 0Details
Commit message · ziggie
chanstate: use htlc type in beacon
Move the witness subscription HTLC parameter to chanstate.HTLC.
The beacon still depends on channeldb for witness-cache errors, but it no longer needs the channel DB compatibility alias for HTLC payloads.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Copy all HTLC fields when cloning channel commitment state.
The old copy method only copied a subset of scalar fields and copied into nil slices for Signature and ExtraData. Allocate those slices and deep-copy custom record values so snapshots and channel copies retain complete HTLC metadata.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI review queuedchanstate: remove store genericsby ziggie · 68ad283d · Jul 6, 2026 · 15 filesMessage 58 · ThinTriage 12Details
Commit message · ziggie
chanstate: remove store generics
Drop the temporary channel type parameter from the channel-state store interfaces now that OpenChannel lives in chanstate.
The domain store subinterfaces now refer to *OpenChannel directly while retaining the same backend-independent shape. Update callers and compatibility aliases to use the concrete Store and ChannelShell types.