SeedSigner

This commit makes small, non-security improvements to how SeedSigner discovers language files and how settings are exported. It removes a script that could write a settings definition file to a microSD card, but that script only ran when a developer manually executed the file. There is no clear security vulnerability being fixed.

This commit is a non-security change. It renames the user-facing label 'MicroSD toast timer' to 'MicroSD notification duration' and adds two translator comments to help people translate the terms into other languages. No code behavior changes.

This commit only wraps a few user-visible English text strings with translation markers so they can be translated into other languages. It does not change program logic, access controls, cryptography, or any security behavior. There is no security issue here.

This commit is a minor localization (translation) improvement. It changes how a user-facing error message is assembled so translators can more easily work with named placeholders instead of numbered ones. There is no security-relevant change.

This is a tiny code cleanup commit in a single display driver file. It adds the Python dataclass decorator to a class and renames one method parameter from 'state' to 'enabled' to match the rest of the code. There is no visible security relevance.

This commit is a routine internal code cleanup. It renames the parent display class from DisplayDriver to BaseDisplayDriver, makes a couple of methods optional instead of requiring every display subclass to implement them, and adjusts the ILI9341 display driver to inherit from the new base class. There is no visible security fix or vulnerability being addressed.

This commit is a routine internal code reorganization. It restructures how the SeedSigner app creates and manages its screen drivers, turning the existing display controller into a parent class and adding a factory pattern. There is no indication this change fixes a security bug or introduces a security vulnerability.

This commit hardens how SeedSigner loads multiselect settings from saved files or QR codes. Previously, an empty or malformed multiselect value (for example, an empty string, a lone comma, or a missing entry) could leave the setting empty, which might cause unexpected behavior when the app later uses that setting. The patch now strips empty pieces from comma-separated input and falls back to the default value whenever the result is empty. A new test checks four empty/missing cases.

This commit fixes a bug in how SeedSigner reloads saved settings. If a setting that is supposed to be a list of choices (a 'multiselect') was saved as empty/None, the app could behave incorrectly. The patch makes the app fall back to the default list instead. It is a defensive fix rather than a clear-cut remote exploit.

This commit fixes a bug in how SeedSigner reads setup information from a QR code. Previously, if a setting value was left blank (for example, 'sigs=' with nothing after the equals sign), the app would silently accept it and could misinterpret later settings. Now the app rejects blank values and reports an error. This is a defensive hardening change rather than a confirmed exploit, but it prevents potential misconfiguration or unexpected behavior.

This commit adds a user-experience guard so that settings where multiple options can be toggled now require at least one option to remain selected. Previously, a user could back out of such a setting with nothing selected, which could leave the device in an unintended or non-functional configuration. The fix shows a warning and returns the user to the setting until they pick at least one option.

This commit adds a helper function that decides whether the running software is an official release image. It then uses that helper to hide extra technical details (fork name and commit hash) from the version screen only for official releases. There is no security fix or vulnerability here; it is a UI refinement with tests.

This commit is a routine improvement to how SeedSigner reads version information during automated GitHub testing. It adds a new environment variable SOURCE_SHA so that when outside contributors open pull requests, the displayed commit hash points to the contributor's actual latest commit rather than a temporary merge commit GitHub creates internally. There is no security vulnerability here.

This commit improves how the SeedSigner software detects its own version information when running automated tests in GitHub Actions. It adds new environment variables so that pull request builds correctly show the contributor's branch name and username instead of misleading placeholder values. There is no security vulnerability here; it is a quality-of-life improvement for build metadata.

This commit fixes a small date-parsing bug in the software's version helper. When the code runs in GitHub Actions, Git reports the latest commit time ending in 'Z' (a common UTC notation), but the Python function used to read that date didn't understand 'Z' before Python 3.11. The patch simply replaces 'Z' with '+00:00' so the date parses correctly. It is a compatibility fix, not a security fix.

This commit refactors how SeedSigner determines and records its software version. It removes an environment-variable-based build path and instead reads version info directly from git. The change is mostly cleanup and testing improvements. There is no obvious security vulnerability, but the code still uses shell commands (os.popen) and parses git output, which can be risky if inputs are ever attacker-controlled. Here, the inputs come from the local git state or trusted environment variables, so the practical risk is low.

This commit simplifies a custom camera error exception by removing a hard-coded user-facing error message. The exception still exists and will still be raised; it just no longer automatically includes the text 'Camera error. Check camera connections.' There is no security-relevant change visible in the diff.

This commit is a routine code cleanup and build-system improvement. It renames internal variables (for example, changing 'version_commit_hash' to 'short_commit_hash'), makes the version string consistently include a 'v' prefix, and adds explicit support for detecting the SeedSigner OS build environment. There is no change that affects security or user safety.

This commit simply moves a block of existing code (the git shell command helpers) to a different location in the same file and renames a couple of test methods. No behavior changes, no security fixes, and no new vulnerabilities are introduced.

This commit is purely a code cleanup and test expansion. It renames internal helper methods in the version utility to be clearer (for example, changing `_get_version_name_from_env_var` to `_get_version_name_from_seedsigner_os_env_var`), reorganizes comments, and adds new tests to keep test coverage at 100%. There is no change to user-facing behavior, no fix for a bug, and no security-related change.

This commit restores a helper function that lets the project’s screenshot generator temporarily override version information shown in screenshots. The function is decorated so it cannot run on the actual SeedSigner OS device. It only affects display text used in documentation screenshots, not private keys, seeds, or transaction logic.

This commit is a routine internal refactor of how the app reads its own version information (version name, fork, timestamp, commit hash). It consolidates singleton setup, renames constants and methods, adds GitHub Actions CI detection, and expands unit tests to reach 100% code coverage. There is no direct evidence in the commit that this fixes a security vulnerability or introduces a new attack path. The changes are mostly about making version reporting more reliable and testable.

This commit is mostly a routine code cleanup and test expansion for how SeedSigner reports its software version. It renames a decorator, adds more tests, improves error handling when files are missing, and fixes a timestamp formatting bug when checking GitHub releases. There is no direct evidence in the commit that this fixes an active security vulnerability, but it does reduce risky behavior such as silently swallowing errors and making unverified shell calls in some contexts.

This is a large code refactor that changes how SeedSigner detects and displays its software version. It replaces a simple version reader with a more complex singleton system that reads git state, environment variables, and a JSON file. The changes are mostly about version reporting and do not appear to alter how private keys, seeds, or Bitcoin transactions are handled. There is no clear security bug visible in the diff, but the refactor introduces new code paths that touch files and shell commands, which always carry some risk of mistakes.

This commit fixes a bug in how SeedSigner determines and reports its software version. Previously, the version was set once and could be left blank or stale in certain build situations. The patch makes version detection more reliable by trying multiple sources: an environment variable, the current Git branch, the latest Git tag, and finally the short commit hash. There is no direct evidence this is a security fix, but reliable version reporting helps users and developers confirm they are running the expected software.