psbt, test: remove address type restrictions in test
What the developer wrote
Authored by rkrux
psbt, test: remove address type restrictions in test
Because the corresponding Taproot fields were added in PSBT in PR 22558, so
these restrictions are no longer necessary.
What changed, and why it matters
This is a minor test-only cleanup. It removes a TODO comment and two command-line flags that forced a specific address type in one of Bitcoin Core's automated functional tests. The change has no effect on production code, user wallets, or network behavior.
No action required. This is a benign test maintenance change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies test/functional/rpc_psbt.py, dropping ‘-addresstype=bech32’ and ‘-changetype=bech32’ from the first test node’s extra_args and removing the associated TODO. The commit message explains that Taproot PSBT fields were added in PR 22558, making the restriction unnecessary. No consensus, wallet, or P2P code is changed.
Changed components
test/functional/rpc_psbt.pyInspect captured patch +1 / −1
diff --git a/test/functional/rpc_psbt.py b/test/functional/rpc_psbt.py
index 4703ee3b..b7820513 100755
--- a/test/functional/rpc_psbt.py
+++ b/test/functional/rpc_psbt.py
@@ -67,7 +67,7 @@ class PSBTTest(BitcoinTestFramework):
def set_test_params(self):
self.num_nodes = 3
self.extra_args = [
- ["-walletrbf=1", "-addresstype=bech32", "-changetype=bech32"], #TODO: Remove address type restrictions once taproot has psbt extensions
+ ["-walletrbf=1"],
["-walletrbf=0", "-changetype=legacy"],
[]
]
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.