← Watch feed
bench: simplify script verification benchmark, generalize signing
Public commit record
88/100 · Strong
What the developer wrote
Authored by Sebastian Falbesoner
bench: simplify script verification benchmark, generalize signing
Simplify the benchmark with the following changes:
- Set the deterministic private key using uint256::ONE,
put it in a `FlatSigningProvider` instance for easier signing
- Use `GetScriptForDestination` for creating the output script
- Use `SignTransaction` to sign, instead of doing it manually
(also removes the need to caclulate the public key hash manually)
- Pass standard script verification flags instead of combining them manually
These steps, in particular the generalized signing, prepare the
benchmarking extension for a different script type (P2TR key-path) in
the next commit.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
What changed, and why it matters
This commit is a code cleanup inside a performance benchmark file. It changes how a test script creates a fake Bitcoin transaction and signature for timing purposes only. There is no change to the live Bitcoin network code, wallet handling, or consensus rules, and nothing in the commit suggests a security fix or vulnerability.
Recommended action
No security action needed. Treat as ordinary refactoring of benchmark code.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch refactors src/bench/verify_script.cpp to use standard helper functions (GetScriptForDestination, SignTransaction, STANDARD_SCRIPT_VERIFY_FLAGS) instead of hand-rolling key setup, script construction, and witness signing. The benchmark still exercises VerifyScript on a P2WPKH spend with the same deterministic key (uint256::ONE, now compressed). No production logic is modified.
Changed components
src/bench/verify_script.cppInspect captured patch +27 / −26
diff --git a/src/bench/verify_script.cpp b/src/bench/verify_script.cpp
index e740f86c..b8a71dd4 100644
--- a/src/bench/verify_script.cpp
+++ b/src/bench/verify_script.cpp
@@ -2,9 +2,10 @@
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+#include <addresstype.h>
#include <bench/bench.h>
-#include <hash.h>
#include <key.h>
+#include <policy/policy.h>
#include <primitives/transaction.h>
#include <pubkey.h>
#include <script/interpreter.h>
@@ -12,6 +13,7 @@
#include <span.h>
#include <test/util/transaction_utils.h>
#include <uint256.h>
+#include <util/translation.h>
#include <array>
#include <cassert>
@@ -24,32 +26,31 @@ static void VerifyScriptBench(benchmark::Bench& bench)
{
ECC_Context ecc_context{};
- const script_verify_flags flags{SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH};
- const int witnessversion = 0;
-
- // Key pair.
- CKey key;
- static const std::array<unsigned char, 32> vchKey = {
- {
- 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1
- }
- };
- key.Set(vchKey.begin(), vchKey.end(), false);
- CPubKey pubkey = key.GetPubKey();
- uint160 pubkeyHash;
- CHash160().Write(pubkey).Finalize(pubkeyHash);
+ // Create deterministic key material needed for output script creation / signing
+ FlatSigningProvider keystore;
+ CPubKey pubkey;
+ {
+ CKey privkey;
+ privkey.Set(uint256::ONE.begin(), uint256::ONE.end(), /*fCompressedIn=*/true);
+ pubkey = privkey.GetPubKey();
+ CKeyID key_id = pubkey.GetID();
+ keystore.keys.emplace(key_id, privkey);
+ keystore.pubkeys.emplace(key_id, pubkey);
+ }
- // Script.
- CScript scriptPubKey = CScript() << witnessversion << ToByteVector(pubkeyHash);
- CScript scriptSig;
- CScript witScriptPubkey = CScript() << OP_DUP << OP_HASH160 << ToByteVector(pubkeyHash) << OP_EQUALVERIFY << OP_CHECKSIG;
+ // Create crediting and spending transactions
+ CScript scriptPubKey = GetScriptForDestination(WitnessV0KeyHash(pubkey));
const CMutableTransaction& txCredit = BuildCreditingTransaction(scriptPubKey, 1);
- CMutableTransaction txSpend = BuildSpendingTransaction(scriptSig, CScriptWitness(), CTransaction(txCredit));
- CScriptWitness& witness = txSpend.vin[0].scriptWitness;
- witness.stack.emplace_back();
- key.Sign(SignatureHash(witScriptPubkey, txSpend, 0, SIGHASH_ALL, txCredit.vout[0].nValue, SigVersion::WITNESS_V0), witness.stack.back());
- witness.stack.back().push_back(static_cast<unsigned char>(SIGHASH_ALL));
- witness.stack.push_back(ToByteVector(pubkey));
+ CMutableTransaction txSpend = BuildSpendingTransaction(/*scriptSig=*/{}, /*scriptWitness=*/{}, CTransaction(txCredit));
+
+ // Sign spending transaction
+ {
+ std::map<COutPoint, Coin> coins;
+ coins[txSpend.vin[0].prevout] = Coin(txCredit.vout[0], /*nHeightIn=*/100, /*fCoinBaseIn=*/false);
+ std::map<int, bilingual_str> input_errors;
+ bool complete = SignTransaction(txSpend, &keystore, coins, SIGHASH_ALL, input_errors);
+ assert(complete);
+ }
// Benchmark.
bench.run([&] {
@@ -58,7 +59,7 @@ static void VerifyScriptBench(benchmark::Bench& bench)
txSpend.vin[0].scriptSig,
txCredit.vout[0].scriptPubKey,
&txSpend.vin[0].scriptWitness,
- flags,
+ STANDARD_SCRIPT_VERIFY_FLAGS,
MutableTransactionSignatureChecker(&txSpend, 0, txCredit.vout[0].nValue, MissingDataBehavior::ASSERT_FAIL),
&err);
assert(err == SCRIPT_ERR_OK);
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.