← Watch feed
refactor: Enforce readability-avoid-const-params-in-decls
Public commit record
62/100 · Adequate
What the developer wrote
Authored by MarcoFalke
refactor: Enforce readability-avoid-const-params-in-decls
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
What changed, and why it matters
This commit is a pure code-style cleanup. It removes unnecessary 'const' keywords from function parameter declarations in header files across the Bitcoin Core codebase and adds a clang-tidy rule to prevent them from being reintroduced. The 'const' on a value parameter in a declaration has no effect on callers and does not change program behavior, security, or runtime semantics. There is no vulnerability here.
Recommended action
No security action needed. This is a safe refactoring commit. Reviewers can verify that all changes are limited to removing top-level const from value parameters and that the clang-tidy rule is correctly added.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit enforces the clang-tidy check ‘readability-avoid-const-params-in-decls’ and applies it to 48 files. It strips top-level const qualifiers from by-value parameters in function declarations and definitions (e.g., ‘const bool filtered’ becomes ‘bool filtered’, ‘const ChainType chain’ becomes ‘ChainType chain’). In C++, top-level const on a parameter type is ignored in the function type and only matters inside the function body. Therefore, these changes are cosmetic and do not alter ABI, API, or behavior. No functional code, logic, or security boundary is modified.
Changed components
src/.clang-tidyvarious header files across src/ (addrman, chainparams, net, wallet, rpc, script, qt, etc.)Inspect captured patch +83 / −82
diff --git a/src/.clang-tidy b/src/.clang-tidy
index 01153649..a4378cea 100644
--- a/src/.clang-tidy
+++ b/src/.clang-tidy
@@ -24,6 +24,7 @@ performance-*,
-performance-no-int-to-ptr,
-performance-noexcept-move-constructor,
-performance-unnecessary-value-param,
+readability-avoid-const-params-in-decls,
readability-const-return-type,
readability-container-contains,
readability-redundant-declaration,
diff --git a/src/addrman.h b/src/addrman.h
index 3a323014..8368e30b 100644
--- a/src/addrman.h
+++ b/src/addrman.h
@@ -172,7 +172,7 @@ public:
*
* @return A vector of randomly selected addresses from vRandom.
*/
- std::vector<CAddress> GetAddr(size_t max_addresses, size_t max_pct, std::optional<Network> network, const bool filtered = true) const;
+ std::vector<CAddress> GetAddr(size_t max_addresses, size_t max_pct, std::optional<Network> network, bool filtered = true) const;
/**
* Returns an information-location pair for all addresses in the selected addrman table.
diff --git a/src/addrman_impl.h b/src/addrman_impl.h
index f825d20b..c1716f89 100644
--- a/src/addrman_impl.h
+++ b/src/addrman_impl.h
@@ -135,7 +135,7 @@ public:
std::pair<CAddress, NodeSeconds> Select(bool new_only, const std::unordered_set<Network>& networks) const
EXCLUSIVE_LOCKS_REQUIRED(!cs);
- std::vector<CAddress> GetAddr(size_t max_addresses, size_t max_pct, std::optional<Network> network, const bool filtered = true) const
+ std::vector<CAddress> GetAddr(size_t max_addresses, size_t max_pct, std::optional<Network> network, bool filtered = true) const
EXCLUSIVE_LOCKS_REQUIRED(!cs);
std::vector<std::pair<AddrInfo, AddressPosition>> GetEntries(bool from_tried) const
@@ -267,7 +267,7 @@ private:
* */
nid_type GetEntry(bool use_tried, size_t bucket, size_t position) const EXCLUSIVE_LOCKS_REQUIRED(cs);
- std::vector<CAddress> GetAddr_(size_t max_addresses, size_t max_pct, std::optional<Network> network, const bool filtered = true) const EXCLUSIVE_LOCKS_REQUIRED(cs);
+ std::vector<CAddress> GetAddr_(size_t max_addresses, size_t max_pct, std::optional<Network> network, bool filtered = true) const EXCLUSIVE_LOCKS_REQUIRED(cs);
std::vector<std::pair<AddrInfo, AddressPosition>> GetEntries_(bool from_tried) const EXCLUSIVE_LOCKS_REQUIRED(cs);
diff --git a/src/chainparams.h b/src/chainparams.h
index 571e9e17..732949e8 100644
--- a/src/chainparams.h
+++ b/src/chainparams.h
@@ -15,7 +15,7 @@ class ArgsManager;
/**
* Creates and returns a std::unique_ptr<CChainParams> of the chosen chain.
*/
-std::unique_ptr<const CChainParams> CreateChainParams(const ArgsManager& args, const ChainType chain);
+std::unique_ptr<const CChainParams> CreateChainParams(const ArgsManager& args, ChainType chain);
/**
* Return the currently selected parameters. This won't change after app
@@ -26,6 +26,6 @@ const CChainParams &Params();
/**
* Sets the params returned by Params() to those for the given chain type.
*/
-void SelectParams(const ChainType chain);
+void SelectParams(ChainType chain);
#endif // BITCOIN_CHAINPARAMS_H
diff --git a/src/chainparamsbase.h b/src/chainparamsbase.h
index 37e69b32..1407f196 100644
--- a/src/chainparamsbase.h
+++ b/src/chainparamsbase.h
@@ -35,7 +35,7 @@ private:
/**
* Creates and returns a std::unique_ptr<CBaseChainParams> of the chosen chain.
*/
-std::unique_ptr<CBaseChainParams> CreateBaseChainParams(const ChainType chain);
+std::unique_ptr<CBaseChainParams> CreateBaseChainParams(ChainType chain);
/**
*Set the arguments for chainparams
@@ -49,7 +49,7 @@ void SetupChainParamsBaseOptions(ArgsManager& argsman);
const CBaseChainParams& BaseParams();
/** Sets the params returned by Params() to those for the given chain. */
-void SelectBaseParams(const ChainType chain);
+void SelectBaseParams(ChainType chain);
/** List of possible chain / network names */
#define LIST_CHAIN_NAMES "main, test, testnet4, signet, regtest"
diff --git a/src/common/bloom.h b/src/common/bloom.h
index bff96a23..97007e1f 100644
--- a/src/common/bloom.h
+++ b/src/common/bloom.h
@@ -61,7 +61,7 @@ public:
* It should generally always be a random value (and is largely only exposed for unit testing)
* nFlags should be one of the BLOOM_UPDATE_* enums (not _MASK)
*/
- CBloomFilter(const unsigned int nElements, const double nFPRate, const unsigned int nTweak, unsigned char nFlagsIn);
+ CBloomFilter(unsigned int nElements, double nFPRate, unsigned int nTweak, unsigned char nFlagsIn);
CBloomFilter() : nHashFuncs(0), nTweak(0), nFlags(0) {}
SERIALIZE_METHODS(CBloomFilter, obj) { READWRITE(obj.vData, obj.nHashFuncs, obj.nTweak, obj.nFlags); }
@@ -108,7 +108,7 @@ public:
class CRollingBloomFilter
{
public:
- CRollingBloomFilter(const unsigned int nElements, const double nFPRate);
+ CRollingBloomFilter(unsigned int nElements, double nFPRate);
void insert(std::span<const unsigned char> vKey);
bool contains(std::span<const unsigned char> vKey) const;
diff --git a/src/common/messages.h b/src/common/messages.h
index 4cabdc79..60fdaa18 100644
--- a/src/common/messages.h
+++ b/src/common/messages.h
@@ -31,7 +31,7 @@ std::string FeeModeInfo(std::pair<std::string, FeeEstimateMode>& mode);
std::string FeeModesDetail(std::string default_info);
std::string InvalidEstimateModeErrorMessage();
bilingual_str PSBTErrorString(PSBTError error);
-bilingual_str TransactionErrorString(const node::TransactionError error);
+bilingual_str TransactionErrorString(node::TransactionError error);
bilingual_str ResolveErrMsg(const std::string& optname, const std::string& strBind);
bilingual_str InvalidPortErrMsg(const std::string& optname, const std::string& strPort);
bilingual_str AmountHighWarn(const std::string& optname);
diff --git a/src/common/signmessage.h b/src/common/signmessage.h
index 4533875a..c2152f35 100644
--- a/src/common/signmessage.h
+++ b/src/common/signmessage.h
@@ -72,6 +72,6 @@ bool MessageSign(
*/
uint256 MessageHash(const std::string& message);
-std::string SigningResultString(const SigningResult res);
+std::string SigningResultString(SigningResult res);
#endif // BITCOIN_COMMON_SIGNMESSAGE_H
diff --git a/src/core_io.h b/src/core_io.h
index f768590c..113a961f 100644
--- a/src/core_io.h
+++ b/src/core_io.h
@@ -34,7 +34,7 @@ enum class TxVerbosity {
// core_read.cpp
CScript ParseScript(const std::string& s);
-std::string ScriptToAsmStr(const CScript& script, const bool fAttemptSighashDecode = false);
+std::string ScriptToAsmStr(const CScript& script, bool fAttemptSighashDecode = false);
[[nodiscard]] bool DecodeHexTx(CMutableTransaction& tx, const std::string& hex_tx, bool try_no_witness = false, bool try_witness = true);
[[nodiscard]] bool DecodeHexBlk(CBlock&, const std::string& strHexBlk);
bool DecodeHexBlockHeader(CBlockHeader&, const std::string& hex_header);
@@ -42,7 +42,7 @@ bool DecodeHexBlockHeader(CBlockHeader&, const std::string& hex_header);
[[nodiscard]] util::Result<int> SighashFromStr(const std::string& sighash);
// core_write.cpp
-UniValue ValueFromAmount(const CAmount amount);
+UniValue ValueFromAmount(CAmount amount);
std::string FormatScript(const CScript& script);
std::string EncodeHexTx(const CTransaction& tx);
std::string SighashToStr(unsigned char sighash_type);
diff --git a/src/crypto/hex_base.h b/src/crypto/hex_base.h
index 9975f7f6..286720af 100644
--- a/src/crypto/hex_base.h
+++ b/src/crypto/hex_base.h
@@ -15,9 +15,9 @@
/**
* Convert a span of bytes to a lower-case hexadecimal string.
*/
-std::string HexStr(const std::span<const uint8_t> s);
-inline std::string HexStr(const std::span<const char> s) { return HexStr(MakeUCharSpan(s)); }
-inline std::string HexStr(const std::span<const std::byte> s) { return HexStr(MakeUCharSpan(s)); }
+std::string HexStr(std::span<const uint8_t> s);
+inline std::string HexStr(std::span<const char> s) { return HexStr(MakeUCharSpan(s)); }
+inline std::string HexStr(std::span<const std::byte> s) { return HexStr(MakeUCharSpan(s)); }
signed char HexDigit(char c);
diff --git a/src/deploymentinfo.h b/src/deploymentinfo.h
index 875505c1..dc3ef723 100644
--- a/src/deploymentinfo.h
+++ b/src/deploymentinfo.h
@@ -30,6 +30,6 @@ inline std::string DeploymentName(Consensus::DeploymentPos pos)
return VersionBitsDeploymentInfo[pos].name;
}
-std::optional<Consensus::BuriedDeployment> GetBuriedDeployment(const std::string_view deployment_name);
+std::optional<Consensus::BuriedDeployment> GetBuriedDeployment(std::string_view deployment_name);
#endif // BITCOIN_DEPLOYMENTINFO_H
diff --git a/src/external_signer.h b/src/external_signer.h
index 5d23cef4..1b36d496 100644
--- a/src/external_signer.h
+++ b/src/external_signer.h
@@ -55,7 +55,7 @@ public:
//! Calls `<command> getdescriptors --account <account>`
//! @param[in] account which BIP32 account to use (e.g. `m/44'/0'/account'`)
//! @returns see doc/external-signer.md
- UniValue GetDescriptors(const int account);
+ UniValue GetDescriptors(int account);
//! Sign PartiallySignedTransaction on the device.
//! Calls `<command> signtransaction` and passes the PSBT via stdin.
diff --git a/src/interfaces/mining.h b/src/interfaces/mining.h
index 07ec5f9c..993f70bd 100644
--- a/src/interfaces/mining.h
+++ b/src/interfaces/mining.h
@@ -105,7 +105,7 @@ public:
* On testnet this will additionally return a template with difficulty 1 if
* the tip is more than 20 minutes old.
*/
- virtual std::unique_ptr<BlockTemplate> waitNext(const node::BlockWaitOptions options = {}) = 0;
+ virtual std::unique_ptr<BlockTemplate> waitNext(node::BlockWaitOptions options = {}) = 0;
/**
* Interrupts the current wait for the next block template.
diff --git a/src/interfaces/wallet.h b/src/interfaces/wallet.h
index 3ca0738c..40c612a4 100644
--- a/src/interfaces/wallet.h
+++ b/src/interfaces/wallet.h
@@ -95,7 +95,7 @@ public:
virtual std::string getWalletName() = 0;
// Get a new address.
- virtual util::Result<CTxDestination> getNewDestination(const OutputType type, const std::string& label) = 0;
+ virtual util::Result<CTxDestination> getNewDestination(OutputType type, const std::string& label) = 0;
//! Get public key.
virtual bool getPubKey(const CScript& script, const CKeyID& address, CPubKey& pub_key) = 0;
@@ -130,7 +130,7 @@ public:
virtual util::Result<void> displayAddress(const CTxDestination& dest) = 0;
//! Lock coin.
- virtual bool lockCoin(const COutPoint& output, const bool write_to_db) = 0;
+ virtual bool lockCoin(const COutPoint& output, bool write_to_db) = 0;
//! Unlock coin.
virtual bool unlockCoin(const COutPoint& output) = 0;
diff --git a/src/kernel/bitcoinkernel.h b/src/kernel/bitcoinkernel.h
index 0ee41adc..53a760cd 100644
--- a/src/kernel/bitcoinkernel.h
+++ b/src/kernel/bitcoinkernel.h
@@ -760,7 +760,7 @@ BITCOINKERNEL_API void btck_logging_disable();
*
* @param[in] options Sets formatting options of the log messages.
*/
-BITCOINKERNEL_API void btck_logging_set_options(const btck_LoggingOptions options);
+BITCOINKERNEL_API void btck_logging_set_options(btck_LoggingOptions options);
/**
* @brief Set the log level of the global internal logger. This does not
@@ -835,7 +835,7 @@ BITCOINKERNEL_API void btck_logging_connection_destroy(btck_LoggingConnection* l
* @return An allocated chain parameters opaque struct.
*/
BITCOINKERNEL_API btck_ChainParameters* BITCOINKERNEL_WARN_UNUSED_RESULT btck_chain_parameters_create(
- const btck_ChainType chain_type);
+ btck_ChainType chain_type);
/**
* Copy the chain parameters.
diff --git a/src/net.h b/src/net.h
index e7047c5b..2fa7c2de 100644
--- a/src/net.h
+++ b/src/net.h
@@ -421,7 +421,7 @@ private:
size_t m_bytes_sent GUARDED_BY(m_send_mutex) {0};
public:
- explicit V1Transport(const NodeId node_id) noexcept;
+ explicit V1Transport(NodeId node_id) noexcept;
bool ReceivedMessageComplete() const override EXCLUSIVE_LOCKS_REQUIRED(!m_recv_mutex)
{
@@ -1294,7 +1294,7 @@ public:
* @param[in] network Select only addresses of this network (nullopt = all).
* @param[in] filtered Select only addresses that are considered high quality (false = all).
*/
- std::vector<CAddress> GetAddressesUnsafe(size_t max_addresses, size_t max_pct, std::optional<Network> network, const bool filtered = true) const;
+ std::vector<CAddress> GetAddressesUnsafe(size_t max_addresses, size_t max_pct, std::optional<Network> network, bool filtered = true) const;
/**
* Return addresses from the per-requestor cache. If no cache entry exists, it is populated with
* randomly selected addresses. This function can be used in untrusted contexts.
diff --git a/src/net_processing.cpp b/src/net_processing.cpp
index 84c0ba9c..8939156b 100644
--- a/src/net_processing.cpp
+++ b/src/net_processing.cpp
@@ -552,7 +552,7 @@ public:
};
void UnitTestMisbehaving(NodeId peer_id) override EXCLUSIVE_LOCKS_REQUIRED(!m_peer_mutex) { Misbehaving(*Assert(GetPeerRef(peer_id)), ""); };
void ProcessMessage(CNode& pfrom, const std::string& msg_type, DataStream& vRecv,
- const std::chrono::microseconds time_received, const std::atomic<bool>& interruptMsgProc) override
+ std::chrono::microseconds time_received, const std::atomic<bool>& interruptMsgProc) override
EXCLUSIVE_LOCKS_REQUIRED(!m_peer_mutex, !m_most_recent_block_mutex, !m_headers_presync_mutex, g_msgproc_mutex, !m_tx_download_mutex);
void UpdateLastBlockAnnounceTime(NodeId node, int64_t time_in_seconds) override;
ServiceFlags GetDesirableServiceFlags(ServiceFlags services) const override;
diff --git a/src/net_processing.h b/src/net_processing.h
index 09f348c8..4b221c5d 100644
--- a/src/net_processing.h
+++ b/src/net_processing.h
@@ -149,7 +149,7 @@ public:
/** Process a single message from a peer. Public for fuzz testing */
virtual void ProcessMessage(CNode& pfrom, const std::string& msg_type, DataStream& vRecv,
- const std::chrono::microseconds time_received, const std::atomic<bool>& interruptMsgProc) EXCLUSIVE_LOCKS_REQUIRED(g_msgproc_mutex) = 0;
+ std::chrono::microseconds time_received, const std::atomic<bool>& interruptMsgProc) EXCLUSIVE_LOCKS_REQUIRED(g_msgproc_mutex) = 0;
/** This function is used for testing the stale tip eviction logic, see denialofservice_tests.cpp */
virtual void UpdateLastBlockAnnounceTime(NodeId node, int64_t time_in_seconds) = 0;
diff --git a/src/netaddress.h b/src/netaddress.h
index c6556809..2191da54 100644
--- a/src/netaddress.h
+++ b/src/netaddress.h
@@ -206,7 +206,7 @@ public:
std::vector<unsigned char> GetAddrBytes() const;
int GetReachabilityFrom(const CNetAddr& paddrPartner) const;
- explicit CNetAddr(const struct in6_addr& pipv6Addr, const uint32_t scope = 0);
+ explicit CNetAddr(const struct in6_addr& pipv6Addr, uint32_t scope = 0);
bool GetIn6Addr(struct in6_addr* pipv6Addr) const;
friend bool operator==(const CNetAddr& a, const CNetAddr& b);
diff --git a/src/node/blockstorage.h b/src/node/blockstorage.h
index 3fb6cc3e..d8b716e9 100644
--- a/src/node/blockstorage.h
+++ b/src/node/blockstorage.h
@@ -370,7 +370,7 @@ public:
CBlockIndex* InsertBlockIndex(const uint256& hash) EXCLUSIVE_LOCKS_REQUIRED(cs_main);
//! Mark one block file as pruned (modify associated database entries)
- void PruneOneBlockFile(const int fileNumber) EXCLUSIVE_LOCKS_REQUIRED(cs_main);
+ void PruneOneBlockFile(int fileNumber) EXCLUSIVE_LOCKS_REQUIRED(cs_main);
CBlockIndex* LookupBlockIndex(const uint256& hash) EXCLUSIVE_LOCKS_REQUIRED(cs_main);
const CBlockIndex* LookupBlockIndex(const uint256& hash) const EXCLUSIVE_LOCKS_REQUIRED(cs_main);
diff --git a/src/node/miner.h b/src/node/miner.h
index f4bebb51..0c268f18 100644
--- a/src/node/miner.h
+++ b/src/node/miner.h
@@ -128,7 +128,7 @@ private:
* accounts for the BIP94 timewarp rule, so does not necessarily reflect the
* consensus limit.
*/
-int64_t GetMinimumTime(const CBlockIndex* pindexPrev, const int64_t difficulty_adjustment_interval);
+int64_t GetMinimumTime(const CBlockIndex* pindexPrev, int64_t difficulty_adjustment_interval);
int64_t UpdateTime(CBlockHeader* pblock, const Consensus::Params& consensusParams, const CBlockIndex* pindexPrev);
diff --git a/src/node/transaction.h b/src/node/transaction.h
index e2f237ec..d27057a4 100644
--- a/src/node/transaction.h
+++ b/src/node/transaction.h
@@ -70,7 +70,7 @@ static const CAmount DEFAULT_MAX_BURN_AMOUNT{0};
* @param[out] hashBlock The block hash, if the tx was found via -txindex or block_index
* @returns The tx if found, otherwise nullptr
*/
-CTransactionRef GetTransaction(const CBlockIndex* const block_index, const CTxMemPool* const mempool, const Txid& hash, const BlockManager& blockman, uint256& hashBlock);
+CTransactionRef GetTransaction(const CBlockIndex* block_index, const CTxMemPool* mempool, const Txid& hash, const BlockManager& blockman, uint256& hashBlock);
} // namespace node
#endif // BITCOIN_NODE_TRANSACTION_H
diff --git a/src/policy/fees/block_policy_estimator.h b/src/policy/fees/block_policy_estimator.h
index ec432dcb..505eed08 100644
--- a/src/policy/fees/block_policy_estimator.h
+++ b/src/policy/fees/block_policy_estimator.h
@@ -200,7 +200,7 @@ private:
const fs::path m_estimation_filepath;
public:
/** Create new BlockPolicyEstimator and initialize stats tracking classes with default values */
- CBlockPolicyEstimator(const fs::path& estimation_filepath, const bool read_stale_estimates);
+ CBlockPolicyEstimator(const fs::path& estimation_filepath, bool read_stale_estimates);
virtual ~CBlockPolicyEstimator();
/** Process all the transactions that have been included in a block */
diff --git a/src/pow.h b/src/pow.h
index 7ee1bddd..26004c46 100644
--- a/src/pow.h
+++ b/src/pow.h
@@ -24,7 +24,7 @@ class arith_uint256;
* @return the proof-of-work target or nullopt if the nBits value
* is invalid (due to overflow or exceeding pow_limit)
*/
-std::optional<arith_uint256> DeriveTarget(unsigned int nBits, const uint256 pow_limit);
+std::optional<arith_uint256> DeriveTarget(unsigned int nBits, uint256 pow_limit);
unsigned int GetNextWorkRequired(const CBlockIndex* pindexLast, const CBlockHeader *pblock, const Consensus::Params&);
unsigned int CalculateNextWorkRequired(const CBlockIndex* pindexLast, int64_t nFirstBlockTime, const Consensus::Params&);
diff --git a/src/qt/addresstablemodel.h b/src/qt/addresstablemodel.h
index 4bfacc56..127378ed 100644
--- a/src/qt/addresstablemodel.h
+++ b/src/qt/addresstablemodel.h
@@ -70,7 +70,7 @@ public:
/* Add an address to the model.
Returns the added address on success, and an empty string otherwise.
*/
- QString addRow(const QString &type, const QString &label, const QString &address, const OutputType address_type);
+ QString addRow(const QString& type, const QString& label, const QString& address, OutputType address_type);
/** Look up label for address in address book, if not found return empty string. */
QString labelForAddress(const QString &address) const;
diff --git a/src/qt/networkstyle.h b/src/qt/networkstyle.h
index ac103ee7..2c6cc821 100644
--- a/src/qt/networkstyle.h
+++ b/src/qt/networkstyle.h
@@ -16,7 +16,7 @@ class NetworkStyle
{
public:
/** Get style associated with provided network id, or 0 if not known */
- static const NetworkStyle* instantiate(const ChainType networkId);
+ static const NetworkStyle* instantiate(ChainType networkId);
const QString &getAppName() const { return appName; }
const QIcon &getAppIcon() const { return appIcon; }
@@ -24,7 +24,7 @@ public:
const QString &getTitleAddText() const { return titleAddText; }
private:
- NetworkStyle(const QString &appName, const int iconColorHueShift, const int iconColorSaturationReduction, const char *titleAddText);
+ NetworkStyle(const QString& appName, int iconColorHueShift, int iconColorSaturationReduction, const char* titleAddText);
QString appName;
QIcon appIcon;
diff --git a/src/qt/rpcconsole.h b/src/qt/rpcconsole.h
index 53dccd7d..bbd469cd 100644
--- a/src/qt/rpcconsole.h
+++ b/src/qt/rpcconsole.h
@@ -48,7 +48,7 @@ public:
explicit RPCConsole(interfaces::Node& node, const PlatformStyle *platformStyle, QWidget *parent);
~RPCConsole();
- static bool RPCParseCommandLine(interfaces::Node* node, std::string &strResult, const std::string &strCommand, bool fExecute, std::string * const pstrFilteredOut = nullptr, const QString& wallet_name = {});
+ static bool RPCParseCommandLine(interfaces::Node* node, std::string& strResult, const std::string& strCommand, bool fExecute, std::string* pstrFilteredOut = nullptr, const QString& wallet_name = {});
static bool RPCExecuteCommandLine(interfaces::Node& node, std::string &strResult, const std::string &strCommand, std::string * const pstrFilteredOut = nullptr, const QString& wallet_name = {}) {
return RPCParseCommandLine(&node, strResult, strCommand, true, pstrFilteredOut, wallet_name);
}
@@ -56,8 +56,8 @@ public:
void setClientModel(ClientModel *model = nullptr, int bestblock_height = 0, int64_t bestblock_date = 0, double verification_progress = 0.0);
#ifdef ENABLE_WALLET
- void addWallet(WalletModel* const walletModel);
- void removeWallet(WalletModel* const walletModel);
+ void addWallet(WalletModel* walletModel);
+ void removeWallet(WalletModel* walletModel);
#endif // ENABLE_WALLET
enum MessageClass {
@@ -138,7 +138,7 @@ public Q_SLOTS:
void setTabFocus(enum TabTypes tabType);
#ifdef ENABLE_WALLET
/** Set the current (ie - active) wallet */
- void setCurrentWallet(WalletModel* const wallet_model);
+ void setCurrentWallet(WalletModel* wallet_model);
#endif // ENABLE_WALLET
private:
diff --git a/src/random.h b/src/random.h
index 330c10a3..f0c0dcee 100644
--- a/src/random.h
+++ b/src/random.h
@@ -95,7 +95,7 @@ void RandAddPeriodic() noexcept;
*
* Thread-safe.
*/
-void RandAddEvent(const uint32_t event_info) noexcept;
+void RandAddEvent(uint32_t event_info) noexcept;
/* =========================== BASE RANDOMNESS GENERATION FUNCTIONS ===========================
diff --git a/src/rpc/blockchain.h b/src/rpc/blockchain.h
index 0e42bed9..d14a43b2 100644
--- a/src/rpc/blockchain.h
+++ b/src/rpc/blockchain.h
@@ -36,10 +36,10 @@ static constexpr int NUM_GETBLOCKSTATS_PERCENTILES = 5;
double GetDifficulty(const CBlockIndex& blockindex);
/** Block description to JSON */
-UniValue blockToJSON(node::BlockManager& blockman, const CBlock& block, const CBlockIndex& tip, const CBlockIndex& blockindex, TxVerbosity verbosity, const uint256 pow_limit) LOCKS_EXCLUDED(cs_main);
+UniValue blockToJSON(node::BlockManager& blockman, const CBlock& block, const CBlockIndex& tip, const CBlockIndex& blockindex, TxVerbosity verbosity, uint256 pow_limit) LOCKS_EXCLUDED(cs_main);
/** Block header to JSON */
-UniValue blockheaderToJSON(const CBlockIndex& tip, const CBlockIndex& blockindex, const uint256 pow_limit) LOCKS_EXCLUDED(cs_main);
+UniValue blockheaderToJSON(const CBlockIndex& tip, const CBlockIndex& blockindex, uint256 pow_limit) LOCKS_EXCLUDED(cs_main);
/** Used by getblockstats to get feerates at different percentiles by weight */
void CalculatePercentilesByWeight(CAmount result[NUM_GETBLOCKSTATS_PERCENTILES], std::vector<std::pair<CAmount, int64_t>>& scores, int64_t total_weight);
diff --git a/src/rpc/rawtransaction_util.h b/src/rpc/rawtransaction_util.h
index 65e65c37..7bd05122 100644
--- a/src/rpc/rawtransaction_util.h
+++ b/src/rpc/rawtransaction_util.h
@@ -54,7 +54,7 @@ std::vector<std::pair<CTxDestination, CAmount>> ParseOutputs(const UniValue& out
void AddOutputs(CMutableTransaction& rawTx, const UniValue& outputs_in);
/** Create a transaction from univalue parameters */
-CMutableTransaction ConstructTransaction(const UniValue& inputs_in, const UniValue& outputs_in, const UniValue& locktime, std::optional<bool> rbf, const uint32_t version);
+CMutableTransaction ConstructTransaction(const UniValue& inputs_in, const UniValue& outputs_in, const UniValue& locktime, std::optional<bool> rbf, uint32_t version);
/** Explain the UniValue "decoded" transaction object, may include extra fields if processed by wallet **/
std::vector<RPCResult> DecodeTxDoc(const std::string& txid_field_doc, bool wallet);
diff --git a/src/rpc/util.h b/src/rpc/util.h
index f82ccbf8..37530876 100644
--- a/src/rpc/util.h
+++ b/src/rpc/util.h
@@ -136,7 +136,7 @@ std::string HelpExampleRpc(const std::string& methodname, const std::string& arg
std::string HelpExampleRpcNamed(const std::string& methodname, const RPCArgList& args);
CPubKey HexToPubKey(const std::string& hex_in);
-CTxDestination AddAndGetMultisigDestination(const int required, const std::vector<CPubKey>& pubkeys, OutputType type, FlatSigningProvider& keystore, CScript& script_out);
+CTxDestination AddAndGetMultisigDestination(int required, const std::vector<CPubKey>& pubkeys, OutputType type, FlatSigningProvider& keystore, CScript& script_out);
UniValue DescribeAddress(const CTxDestination& dest);
@@ -154,7 +154,7 @@ UniValue JSONRPCTransactionError(node::TransactionError terr, const std::string&
std::pair<int64_t, int64_t> ParseDescriptorRange(const UniValue& value);
/** Evaluate a descriptor given as a string, or as a {"desc":...,"range":...} object, with default range of 1000. */
-std::vector<CScript> EvalDescriptorStringOrObject(const UniValue& scanobject, FlatSigningProvider& provider, const bool expand_priv = false);
+std::vector<CScript> EvalDescriptorStringOrObject(const UniValue& scanobject, FlatSigningProvider& provider, bool expand_priv = false);
/**
* Serializing JSON objects depends on the outer type. Only arrays and
@@ -372,7 +372,7 @@ struct RPCResult {
: RPCResult{type, std::move(m_key_name), /*optional=*/false, std::move(description), std::move(inner), skip_type_check} {}
/** Append the sections of the result. */
- void ToSections(Sections& sections, OuterType outer_type = OuterType::NONE, const int current_indent = 0) const;
+ void ToSections(Sections& sections, OuterType outer_type = OuterType::NONE, int current_indent = 0) const;
/** Return the type string of the result when it is in an object (dict). */
std::string ToStringObj() const;
/** Return the description string, including the result type. */
@@ -527,6 +527,6 @@ std::vector<RPCResult> ScriptPubKeyDoc();
*
* @return the target
*/
-uint256 GetTarget(const CBlockIndex& blockindex, const uint256 pow_limit);
+uint256 GetTarget(const CBlockIndex& blockindex, uint256 pow_limit);
#endif // BITCOIN_RPC_UTIL_H
diff --git a/src/script/miniscript.h b/src/script/miniscript.h
index c71203ed..955ede23 100644
--- a/src/script/miniscript.h
+++ b/src/script/miniscript.h
@@ -1761,7 +1761,7 @@ enum class ParseContext {
CLOSE_BRACKET,
};
-int FindNextChar(std::span<const char> in, const char m);
+int FindNextChar(std::span<const char> in, char m);
/** Parse a key string ending at the end of the fragment's text representation. */
template<typename Key, typename Ctx>
diff --git a/src/script/script_error.h b/src/script/script_error.h
index 198d037c..58ac7db5 100644
--- a/src/script/script_error.h
+++ b/src/script/script_error.h
@@ -88,6 +88,6 @@ typedef enum ScriptError_t
#define SCRIPT_ERR_LAST SCRIPT_ERR_ERROR_COUNT
-std::string ScriptErrorString(const ScriptError error);
+std::string ScriptErrorString(ScriptError error);
#endif // BITCOIN_SCRIPT_SCRIPT_ERROR_H
diff --git a/src/script/sigcache.h b/src/script/sigcache.h
index ca4b4491..fb388096 100644
--- a/src/script/sigcache.h
+++ b/src/script/sigcache.h
@@ -55,7 +55,7 @@ public:
void ComputeEntrySchnorr(uint256& entry, const uint256 &hash, std::span<const unsigned char> sig, const XOnlyPubKey& pubkey) const;
- bool Get(const uint256& entry, const bool erase);
+ bool Get(const uint256& entry, bool erase);
void Set(const uint256& entry);
};
diff --git a/src/test/fuzz/util.h b/src/test/fuzz/util.h
index 0575b157..a7b1bfd5 100644
--- a/src/test/fuzz/util.h
+++ b/src/test/fuzz/util.h
@@ -146,11 +146,11 @@ template <typename WeakEnumType, size_t size>
[[nodiscard]] int64_t ConsumeTime(FuzzedDataProvider& fuzzed_data_provider, const std::optional<int64_t>& min = std::nullopt, const std::optional<int64_t>& max = std::nullopt) noexcept;
-[[nodiscard]] CMutableTransaction ConsumeTransaction(FuzzedDataProvider& fuzzed_data_provider, const std::optional<std::vector<Txid>>& prevout_txids, const int max_num_in = 10, const int max_num_out = 10) noexcept;
+[[nodiscard]] CMutableTransaction ConsumeTransaction(FuzzedDataProvider& fuzzed_data_provider, const std::optional<std::vector<Txid>>& prevout_txids, int max_num_in = 10, int max_num_out = 10) noexcept;
-[[nodiscard]] CScriptWitness ConsumeScriptWitness(FuzzedDataProvider& fuzzed_data_provider, const size_t max_stack_elem_size = 32) noexcept;
+[[nodiscard]] CScriptWitness ConsumeScriptWitness(FuzzedDataProvider& fuzzed_data_provider, size_t max_stack_elem_size = 32) noexcept;
-[[nodiscard]] CScript ConsumeScript(FuzzedDataProvider& fuzzed_data_provider, const bool maybe_p2wsh = false) noexcept;
+[[nodiscard]] CScript ConsumeScript(FuzzedDataProvider& fuzzed_data_provider, bool maybe_p2wsh = false) noexcept;
[[nodiscard]] uint32_t ConsumeSequence(FuzzedDataProvider& fuzzed_data_provider) noexcept;
diff --git a/src/test/util/setup_common.h b/src/test/util/setup_common.h
index fdb0951e..05851e41 100644
--- a/src/test/util/setup_common.h
+++ b/src/test/util/setup_common.h
@@ -73,7 +73,7 @@ struct BasicTestingSetup {
m_rng.Reseed(GetRandHash());
}
- explicit BasicTestingSetup(const ChainType chainType = ChainType::MAIN, TestOpts = {});
+ explicit BasicTestingSetup(ChainType chainType = ChainType::MAIN, TestOpts = {});
~BasicTestingSetup();
fs::path m_path_root;
@@ -109,7 +109,7 @@ struct ChainTestingSetup : public BasicTestingSetup {
bool m_block_tree_db_in_memory{true};
std::function<void()> m_make_chainman{};
- explicit ChainTestingSetup(const ChainType chainType = ChainType::MAIN, TestOpts = {});
+ explicit ChainTestingSetup(ChainType chainType = ChainType::MAIN, TestOpts = {});
~ChainTestingSetup();
// Supplies a chainstate, if one is needed
@@ -120,7 +120,7 @@ struct ChainTestingSetup : public BasicTestingSetup {
*/
struct TestingSetup : public ChainTestingSetup {
explicit TestingSetup(
- const ChainType chainType = ChainType::MAIN,
+ ChainType chainType = ChainType::MAIN,
TestOpts = {});
};
@@ -145,7 +145,7 @@ class CScript;
*/
struct TestChain100Setup : public TestingSetup {
TestChain100Setup(
- const ChainType chain_type = ChainType::REGTEST,
+ ChainType chain_type = ChainType::REGTEST,
TestOpts = {});
/**
diff --git a/src/test/validation_block_tests.cpp b/src/test/validation_block_tests.cpp
index 9f574be8..ec2a4c9c 100644
--- a/src/test/validation_block_tests.cpp
+++ b/src/test/validation_block_tests.cpp
@@ -28,7 +28,7 @@ struct MinerTestingSetup : public RegTestingSetup {
std::shared_ptr<const CBlock> GoodBlock(const uint256& prev_hash);
std::shared_ptr<const CBlock> BadBlock(const uint256& prev_hash);
std::shared_ptr<CBlock> FinalizeBlock(std::shared_ptr<CBlock> pblock);
- void BuildChain(const uint256& root, int height, const unsigned int invalid_rate, const unsigned int branch_rate, const unsigned int max_size, std::vector<std::shared_ptr<const CBlock>>& blocks);
+ void BuildChain(const uint256& root, int height, unsigned int invalid_rate, unsigned int branch_rate, unsigned int max_size, std::vector<std::shared_ptr<const CBlock>>& blocks);
};
} // namespace validation_block_tests
diff --git a/src/txmempool.h b/src/txmempool.h
index 166a0248..bef711d4 100644
--- a/src/txmempool.h
+++ b/src/txmempool.h
@@ -553,7 +553,7 @@ public:
bool CheckPolicyLimits(const CTransactionRef& tx);
/** Removes a transaction from the unbroadcast set */
- void RemoveUnbroadcastTx(const Txid& txid, const bool unchecked = false);
+ void RemoveUnbroadcastTx(const Txid& txid, bool unchecked = false);
/** Returns transactions in unbroadcast set */
std::set<Txid> GetUnbroadcastTxs() const
@@ -662,7 +662,7 @@ public:
using TxHandle = CTxMemPool::txiter;
- TxHandle StageAddition(const CTransactionRef& tx, const CAmount fee, int64_t time, unsigned int entry_height, uint64_t entry_sequence, bool spends_coinbase, int64_t sigops_cost, LockPoints lp);
+ TxHandle StageAddition(const CTransactionRef& tx, CAmount fee, int64_t time, unsigned int entry_height, uint64_t entry_sequence, bool spends_coinbase, int64_t sigops_cost, LockPoints lp);
void StageRemoval(CTxMemPool::txiter it);
diff --git a/src/util/moneystr.h b/src/util/moneystr.h
index ecadf646..ae30bd5f 100644
--- a/src/util/moneystr.h
+++ b/src/util/moneystr.h
@@ -17,7 +17,7 @@
/* Do not use these functions to represent or parse monetary amounts to or from
* JSON but use AmountFromValue and ValueFromAmount for that.
*/
-std::string FormatMoney(const CAmount n);
+std::string FormatMoney(CAmount n);
/** Parse an amount denoted in full coins. E.g. "0.0034" supplied on the command line. **/
std::optional<CAmount> ParseMoney(const std::string& str);
diff --git a/src/wallet/coinselection.h b/src/wallet/coinselection.h
index 79fee40d..0f67d4e3 100644
--- a/src/wallet/coinselection.h
+++ b/src/wallet/coinselection.h
@@ -306,7 +306,7 @@ typedef std::map<CoinEligibilityFilter, OutputGroupTypeMap> FilteredOutputGroups
* @param[in] payment_value Average payment value of the transaction output(s).
* @param[in] change_fee Fee for creating a change output.
*/
-[[nodiscard]] CAmount GenerateChangeTarget(const CAmount payment_value, const CAmount change_fee, FastRandomContext& rng);
+[[nodiscard]] CAmount GenerateChangeTarget(CAmount payment_value, CAmount change_fee, FastRandomContext& rng);
enum class SelectionAlgorithm : uint8_t
{
@@ -317,7 +317,7 @@ enum class SelectionAlgorithm : uint8_t
MANUAL = 4,
};
-std::string GetAlgorithmName(const SelectionAlgorithm algo);
+std::string GetAlgorithmName(SelectionAlgorithm algo);
struct SelectionResult
{
@@ -371,7 +371,7 @@ public:
void AddInputs(const std::set<std::shared_ptr<COutput>>& inputs, bool subtract_fee_outputs);
/** How much individual inputs overestimated the bump fees for shared ancestries */
- void SetBumpFeeDiscount(const CAmount discount);
+ void SetBumpFeeDiscount(CAmount discount);
/** Calculates and stores the waste for this result given the cost of change
* and the opportunity cost of spending these inputs now vs in the future.
@@ -385,7 +385,7 @@ public:
* used if there is change, in which case it must be non-negative.
* @param[in] change_fee The fee for creating a change output
*/
- void RecalculateWaste(const CAmount min_viable_change, const CAmount change_cost, const CAmount change_fee);
+ void RecalculateWaste(CAmount min_viable_change, CAmount change_cost, CAmount change_fee);
[[nodiscard]] CAmount GetWaste() const;
/** Tracks that algorithm was able to exhaustively search the entire combination space before hitting limit of tries */
@@ -432,7 +432,7 @@ public:
* @returns Amount for change output, 0 when there is no change.
*
*/
- CAmount GetChange(const CAmount min_viable_change, const CAmount change_fee) const;
+ CAmount GetChange(CAmount min_viable_change, CAmount change_fee) const;
CAmount GetTarget() const { return m_target; }
diff --git a/src/wallet/crypter.h b/src/wallet/crypter.h
index 0737e561..90871245 100644
--- a/src/wallet/crypter.h
+++ b/src/wallet/crypter.h
@@ -79,7 +79,7 @@ private:
int BytesToKeySHA512AES(std::span<const unsigned char> salt, const SecureString& key_data, int count, unsigned char* key, unsigned char* iv) const;
public:
- bool SetKeyFromPassphrase(const SecureString& key_data, std::span<const unsigned char> salt, const unsigned int rounds, const unsigned int derivation_method);
+ bool SetKeyFromPassphrase(const SecureString& key_data, std::span<const unsigned char> salt, unsigned int rounds, unsigned int derivation_method);
bool Encrypt(const CKeyingMaterial& vchPlaintext, std::vector<unsigned char> &vchCiphertext) const;
bool Decrypt(std::span<const unsigned char> ciphertext, CKeyingMaterial& plaintext) const;
bool SetKey(const CKeyingMaterial& new_key, std::span<const unsigned char> new_iv);
diff --git a/src/wallet/scriptpubkeyman.h b/src/wallet/scriptpubkeyman.h
index fcb107a4..00dd6eed 100644
--- a/src/wallet/scriptpubkeyman.h
+++ b/src/wallet/scriptpubkeyman.h
@@ -337,13 +337,13 @@ public:
mutable RecursiveMutex cs_desc_man;
- util::Result<CTxDestination> GetNewDestination(const OutputType type) override;
+ util::Result<CTxDestination> GetNewDestination(OutputType type) override;
bool IsMine(const CScript& script) const override;
bool CheckDecryptionKey(const CKeyingMaterial& master_key) override;
bool Encrypt(const CKeyingMaterial& master_key, WalletBatch* batch) override;
- util::Result<CTxDestination> GetReservedDestination(const OutputType type, bool internal, int64_t& index) override;
+ util::Result<CTxDestination> GetReservedDestination(OutputType type, bool internal, int64_t& index) override;
void ReturnDestination(int64_t index, bool internal, const CTxDestination& addr) override;
// Tops up the descriptor cache and m_map_script_pub_keys. The cache is stored in the wallet file
@@ -402,7 +402,7 @@ public:
std::unordered_set<CScript, SaltedSipHasher> GetScriptPubKeys(int32_t minimum_index) const;
int32_t GetEndRange() const;
- [[nodiscard]] bool GetDescriptorString(std::string& out, const bool priv) const;
+ [[nodiscard]] bool GetDescriptorString(std::string& out, bool priv) const;
void UpgradeDescriptorCache();
};
diff --git a/src/wallet/spend.h b/src/wallet/spend.h
index a22499f3..b10317f4 100644
--- a/src/wallet/spend.h
+++ b/src/wallet/spend.h
@@ -23,7 +23,7 @@ namespace wallet {
/** Get the marginal bytes if spending the specified output from this transaction.
* Use CoinControl to determine whether to expect signature grinding when calculating the size of the input spend. */
int CalculateMaximumSignedInputSize(const CTxOut& txout, const CWallet* pwallet, const CCoinControl* coin_control);
-int CalculateMaximumSignedInputSize(const CTxOut& txout, const COutPoint outpoint, const SigningProvider* pwallet, bool can_grind_r, const CCoinControl* coin_control);
+int CalculateMaximumSignedInputSize(const CTxOut& txout, COutPoint outpoint, const SigningProvider* pwallet, bool can_grind_r, const CCoinControl* coin_control);
struct TxSize {
int64_t vsize{-1};
int64_t weight{-1};
diff --git a/src/wallet/test/init_test_fixture.h b/src/wallet/test/init_test_fixture.h
index b435527a..a9e38db0 100644
--- a/src/wallet/test/init_test_fixture.h
+++ b/src/wallet/test/init_test_fixture.h
@@ -14,7 +14,7 @@
namespace wallet {
struct InitWalletDirTestingSetup: public BasicTestingSetup {
- explicit InitWalletDirTestingSetup(const ChainType chain_type = ChainType::MAIN);
+ explicit InitWalletDirTestingSetup(ChainType chain_type = ChainType::MAIN);
~InitWalletDirTestingSetup();
void SetWalletDir(const fs::path& walletdir_path);
diff --git a/src/wallet/test/util.h b/src/wallet/test/util.h
index ecedbd90..33f36eb6 100644
--- a/src/wallet/test/util.h
+++ b/src/wallet/test/util.h
@@ -117,7 +117,7 @@ public:
std::unique_ptr<WalletDatabase> CreateMockableWalletDatabase(MockableData records = {});
MockableDatabase& GetMockableDatabase(CWallet& wallet);
-DescriptorScriptPubKeyMan* CreateDescriptor(CWallet& keystore, const std::string& desc_str, const bool success);
+DescriptorScriptPubKeyMan* CreateDescriptor(CWallet& keystore, const std::string& desc_str, bool success);
} // namespace wallet
#endif // BITCOIN_WALLET_TEST_UTIL_H
diff --git a/src/wallet/test/wallet_test_fixture.h b/src/wallet/test/wallet_test_fixture.h
index b268463a..8c5b6661 100644
--- a/src/wallet/test/wallet_test_fixture.h
+++ b/src/wallet/test/wallet_test_fixture.h
@@ -20,7 +20,7 @@ namespace wallet {
/** Testing setup and teardown for wallet.
*/
struct WalletTestingSetup : public TestingSetup {
- explicit WalletTestingSetup(const ChainType chainType = ChainType::MAIN);
+ explicit WalletTestingSetup(ChainType chainType = ChainType::MAIN);
~WalletTestingSetup();
std::unique_ptr<interfaces::WalletLoader> m_wallet_loader;
diff --git a/src/wallet/wallet.h b/src/wallet/wallet.h
index d23c1a94..a36fc121 100644
--- a/src/wallet/wallet.h
+++ b/src/wallet/wallet.h
@@ -444,7 +444,7 @@ private:
* block locator and m_last_block_processed, and registering for
* notifications about new blocks and transactions.
*/
- static bool AttachChain(const std::shared_ptr<CWallet>& wallet, interfaces::Chain& chain, const bool rescan_required, bilingual_str& error, std::vector<bilingual_str>& warnings);
+ static bool AttachChain(const std::shared_ptr<CWallet>& wallet, interfaces::Chain& chain, bool rescan_required, bilingual_str& error, std::vector<bilingual_str>& warnings);
static NodeClock::time_point GetDefaultNextResend();
@@ -648,7 +648,7 @@ public:
//! USER_ABORT.
uint256 last_failed_block;
};
- ScanResult ScanForWalletTransactions(const uint256& start_block, int start_height, std::optional<int> max_height, const WalletRescanReserver& reserver, bool fUpdate, const bool save_progress);
+ ScanResult ScanForWalletTransactions(const uint256& start_block, int start_height, std::optional<int> max_height, const WalletRescanReserver& reserver, bool fUpdate, bool save_progress);
void transactionRemovedFromMempool(const CTransactionRef& tx, MemPoolRemovalReason reason) override;
/** Set the next time this wallet should resend transactions to 12-36 hours from now, ~1 day on average. */
void SetNextResend() { m_next_resend = GetDefaultNextResend(); }
@@ -768,7 +768,7 @@ public:
/**
* Retrieve all the known labels in the address book
*/
- std::set<std::string> ListAddrBookLabels(const std::optional<AddressPurpose> purpose) const EXCLUSIVE_LOCKS_REQUIRED(cs_wallet);
+ std::set<std::string> ListAddrBookLabels(std::optional<AddressPurpose> purpose) const EXCLUSIVE_LOCKS_REQUIRED(cs_wallet);
/**
* Walk-through the address book entries.
@@ -783,8 +783,8 @@ public:
*/
void MarkDestinationsDirty(const std::set<CTxDestination>& destinations) EXCLUSIVE_LOCKS_REQUIRED(cs_wallet);
- util::Result<CTxDestination> GetNewDestination(const OutputType type, const std::string& label);
- util::Result<CTxDestination> GetNewChangeDestination(const OutputType type);
+ util::Result<CTxDestination> GetNewDestination(OutputType type, const std::string& label);
+ util::Result<CTxDestination> GetNewChangeDestination(OutputType type);
bool IsMine(const CTxDestination& dest) const EXCLUSIVE_LOCKS_REQUIRED(cs_wallet);
bool IsMine(const CScript& script) const EXCLUSIVE_LOCKS_REQUIRED(cs_wallet);
diff --git a/src/wallet/walletdb.h b/src/wallet/walletdb.h
index a867a28b..c4466bfa 100644
--- a/src/wallet/walletdb.h
+++ b/src/wallet/walletdb.h
@@ -227,7 +227,7 @@ public:
bool WriteTx(const CWalletTx& wtx);
bool EraseTx(Txid hash);
- bool WriteKeyMetadata(const CKeyMetadata& meta, const CPubKey& pubkey, const bool overwrite);
+ bool WriteKeyMetadata(const CKeyMetadata& meta, const CPubKey& pubkey, bool overwrite);
bool WriteKey(const CPubKey& vchPubKey, const CPrivKey& vchPrivKey, const CKeyMetadata &keyMeta);
bool WriteCryptedKey(const CPubKey& vchPubKey, const std::vector<unsigned char>& vchCryptedSecret, const CKeyMetadata &keyMeta);
bool WriteMasterKey(unsigned int nID, const CMasterKey& kMasterKey);
@@ -268,7 +268,7 @@ public:
//! Delete records of the given types
bool EraseRecords(const std::unordered_set<std::string>& types);
- bool WriteWalletFlags(const uint64_t flags);
+ bool WriteWalletFlags(uint64_t flags);
//! Begin a new transaction
bool TxnBegin();
//! Commit current transaction
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.