Remove io dependency from crypto taproot
What the developer wrote
Authored by Mitchell Bagot
Remove io dependency from crypto taproot
The taproot module in bitcoin's crypto holds only the Signature and
SerializedSignature types. In order to retain the lack of io dep in
crypto, the io based methods on these types should be removed, as they
were on the corresponding ecdsa signature types.
Remove Signature::serialize_to_writer and SerializedSignature::write_to
methods.
What changed, and why it matters
This commit removes two helper methods that wrote Taproot signatures to an output stream. It is a routine internal API cleanup to eliminate an unnecessary dependency on the `io` crate inside the crypto taproot module. There is no security vulnerability here; the change simply mirrors a prior cleanup done for ECDSA signature types.
No security action required. Developers using these removed methods should replace them with `signature.serialize()` followed by their own `writer.write_all(...)` call.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes Signature::serialize_to_writer and SerializedSignature::write_to from bitcoin/src/crypto/taproot.rs, along with the use io::Write import. Callers can still obtain the serialized bytes via Signature::serialize() and SerializedSignature itself (which is byte-array-like), then write those bytes using any writer they choose. The functionality is preserved; only the convenience methods tied to the io trait are removed to keep the crypto module free of io dependency.
Changed components
bitcoin/src/crypto/taproot.rsInspect captured patch +0 / −14
diff --git a/bitcoin/src/crypto/taproot.rs b/bitcoin/src/crypto/taproot.rs
index 07613d7f..fd243b94 100644
--- a/bitcoin/src/crypto/taproot.rs
+++ b/bitcoin/src/crypto/taproot.rs
@@ -14,7 +14,6 @@ use core::str::FromStr;
use arbitrary::{Arbitrary, Unstructured};
use internals::array::ArrayExt;
use internals::{impl_to_hex_from_lower_hex, write_err};
-use io::Write;
pub use self::into_iter::IntoIter;
use crate::hex;
@@ -84,13 +83,6 @@ impl Signature {
}
ser_sig
}
-
- /// Serializes the signature to `writer`.
- #[inline]
- pub fn serialize_to_writer<W: Write + ?Sized>(&self, writer: &mut W) -> Result<(), io::Error> {
- let sig = self.serialize();
- sig.write_to(writer)
- }
}
impl fmt::Display for Signature {
@@ -149,12 +141,6 @@ impl SerializedSignature {
#[inline]
pub fn iter(&self) -> core::slice::Iter<'_, u8> { self.into_iter() }
- /// Writes this serialized signature to a `writer`.
- #[inline]
- pub fn write_to<W: Write + ?Sized>(&self, writer: &mut W) -> Result<(), io::Error> {
- writer.write_all(self)
- }
-
/// Constructs new `SerializedSignature` from data and length.
///
/// # Panics
Why this scored 19/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.