Remove io write helpers from ecdsa signatures
What the developer wrote
Authored by Mitchell Bagot
Remove io write helpers from ecdsa signatures
In the ecdsa module, the SerializedSignature and Signature types have
helper methods for writing to bitcoin-io Write objects. Since we want
to remove the io dependency entirely, and the SerializedSignature can
already be used in a similar way to a slice, there's no point to
retaining them.
Remove Signature::serialize_to_writer and SerializedSignature::write_to.
Adjust existing io test case to use std traits.
What changed, and why it matters
This commit removes two helper methods that wrote ECDSA signatures to a custom I/O writer. It is a straightforward API cleanup to drop a dependency, not a security fix. There is no evidence of a vulnerability being patched.
No security action required; treat as a normal API/dependency refactor.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit deletes Signature::serialize_to_writer and SerializedSignature::write_to from crypto/src/ecdsa.rs and removes the io::Write import. Functionality is replaced by callers using the existing serialize() method, which returns a SerializedSignature that dereferences to a byte slice and can be passed to any standard write_all. The test is updated to use std::io::Write directly. No bounds checks, cryptographic operations, or parsing logic are changed.
Changed components
crypto/src/ecdsa.rsInspect captured patch +4 / −23
diff --git a/crypto/src/ecdsa.rs b/crypto/src/ecdsa.rs
index 3fa39735..9f8f99df 100644
--- a/crypto/src/ecdsa.rs
+++ b/crypto/src/ecdsa.rs
@@ -14,7 +14,6 @@ use core::{fmt, iter};
use arbitrary::{Arbitrary, Unstructured};
use hex_unstable::DisplayHex;
use internals::impl_to_hex_from_lower_hex;
-use io::Write;
#[cfg(feature = "serde")]
use serde::{Deserialize, Serialize};
@@ -81,17 +80,6 @@ impl Signature {
.chain(iter::once(self.sighash_type as u8))
.collect()
}
-
- /// Serializes an ECDSA signature (inner secp256k1 signature in DER format) to a `writer`.
- ///
- /// # Errors
- ///
- /// If the signature bytes cannot be written to the provided `writer`.
- #[inline]
- pub fn serialize_to_writer<W: Write + ?Sized>(&self, writer: &mut W) -> Result<(), io::Error> {
- let sig = self.serialize();
- sig.write_to(writer)
- }
}
impl fmt::Display for Signature {
@@ -152,16 +140,6 @@ impl SerializedSignature {
/// Returns an iterator over bytes of the signature.
#[inline]
pub fn iter(&self) -> core::slice::Iter<'_, u8> { self.into_iter() }
-
- /// Writes this serialized signature to a `writer`.
- ///
- /// # Errors
- ///
- /// If the signature bytes cannot be written to the provided `writer`.
- #[inline]
- pub fn write_to<W: Write + ?Sized>(&self, writer: &mut W) -> Result<(), io::Error> {
- writer.write_all(self)
- }
}
impl fmt::Debug for SerializedSignature {
@@ -374,12 +352,15 @@ impl<'a> Arbitrary<'a> for Signature {
#[cfg(test)]
mod tests {
use alloc::vec;
+ #[cfg(feature = "std")]
+ use std::io::Write;
use super::*;
const TEST_SIGNATURE_HEX: &str = "3046022100839c1fbc5304de944f697c9f4b1d01d1faeba32d751c0f7acb21ac8a0f436a72022100e89bd46bb3a5a62adc679f659b7ce876d83ee297c7a5587b2011c4fcc72eab45";
#[test]
+ #[cfg(feature = "std")]
fn write_serialized_signature() {
let sig = Signature {
signature: secp256k1::ecdsa::Signature::from_str(TEST_SIGNATURE_HEX).unwrap(),
@@ -387,7 +368,7 @@ mod tests {
};
let mut buf = vec![];
- sig.serialize_to_writer(&mut buf).expect("write failed");
+ buf.write_all(&sig.serialize()).expect("write failed");
assert_eq!(sig.to_vec(), buf);
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.