What the developer wrote
Authored by kdmukai
Remove now-unused `has_passphrase` attr
What changed, and why it matters
This commit simply removes an unused attribute called has_passphrase from two screen classes and the two places that passed it in. There is no functional change, no bug fix, and no security relevance visible in the code change.
No security action needed. Treat as routine refactoring.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes the has_passphrase dataclass field from SeedOptionsScreen and SeedExportXpubDetailsScreen, and removes the corresponding keyword arguments in SeedOptionsView and SeedExportXpubDetailsView. The attribute was not referenced anywhere else in the shown diff, so this is a dead-code cleanup with no behavioral or security impact.
Changed components
src/seedsigner/gui/screens/seed_screens.pysrc/seedsigner/views/seed_views.pyInspect captured patch +0 / −4
diff --git a/src/seedsigner/gui/screens/seed_screens.py b/src/seedsigner/gui/screens/seed_screens.py
index 3e15fd9..98b4281 100644
--- a/src/seedsigner/gui/screens/seed_screens.py
+++ b/src/seedsigner/gui/screens/seed_screens.py
@@ -441,7 +441,6 @@ class SeedFinalizeScreen(ButtonListScreen):
@dataclass
class SeedOptionsScreen(ButtonListScreen):
fingerprint: str = None
- has_passphrase: bool = False
def __post_init__(self):
self.top_nav_icon_name = SeedSignerIconConstants.FINGERPRINT
@@ -590,7 +589,6 @@ class SeedExportXpubDetailsScreen(WarningEdgesMixin, ButtonListScreen):
# Customize defaults
is_bottom_list: bool = True
fingerprint: str = None
- has_passphrase: bool = False
derivation_path: str = "m/84'/0'/0'"
xpub: str = "zpub6r..."
diff --git a/src/seedsigner/views/seed_views.py b/src/seedsigner/views/seed_views.py
index 8093318..2d6c6d6 100644
--- a/src/seedsigner/views/seed_views.py
+++ b/src/seedsigner/views/seed_views.py
@@ -597,7 +597,6 @@ class SeedOptionsView(View):
seed_screens.SeedOptionsScreen,
button_data=button_data,
fingerprint=self.seed.get_fingerprint(self.settings.get_value(SettingsConstants.SETTING__NETWORK)),
- has_passphrase=self.seed.passphrase is not None,
)
if selected_menu_num == RET_CODE__BACK_BUTTON:
@@ -958,7 +957,6 @@ class SeedExportXpubDetailsView(View):
selected_menu_num = self.run_screen(
seed_screens.SeedExportXpubDetailsScreen,
fingerprint=fingerprint,
- has_passphrase=self.seed.passphrase is not None,
derivation_path=derivation_path,
xpub=xpub_base58,
)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.