AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 39 Bitcoin

feat(clear_signing): support for calldata formatter. - core changes

Public commit record

What the developer wrote

Authored by PrisionMike

62/100 · Adequate
feat(clear_signing): support for calldata formatter. - core changes

[no changelog]
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
The short version

What changed, and why it matters

This commit adds a new Trezor firmware feature called 'clear signing' for nested Ethereum calls. It lets the device understand when a transaction wraps another contract call (like a router or multicall) and tries to show the user readable details about the inner call instead of just a blob of hex. The change is a feature addition with built-in safeguards: nested parsing is limited to one level, ambiguous fields like sender and value are blocked inside nested calls, and failures fall back to showing raw hex rather than aborting the whole transaction. There is no indication in the commit that this fixes a known security bug; it reads as a defensive new capability.

Recommended action

Treat as a feature commit rather than an urgent security fix. Reviewers should verify that the depth cap, callee override, rejected container paths, and raw fallback are enforced in all code paths, and that host-supplied definition requests cannot bypass matches_call pinning. Fuzzing or additional tests around malformed calldata fields and hostile definition responses would strengthen confidence.

Security signals we found

01

New nested calldata parsing path with explicit depth cap of 1

02

@.to override to callee to prevent token resolution from pointing at the wrapper contract

03

@.from and @.value rejected in nested parse to avoid displaying confidently wrong sender/value

04

Raw-hex fallback for unsupported or malformed inner subcalls instead of failing the outer clear-sign flow

05

matches_call pins requested definition to requested selector/callee/binding context

06

CalldataFormatter subclasses RawFormatter as defense-in-depth so accidental single-value use renders hex rather than crashing clear signing

Risk score

Why this scored 39/100

Our methodology →
Potential impact 8/30
Exploitability 7/25
Stealth signal 6/15
Affected reach 9/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.