AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 21 Bitcoin

Display total amount of external inputs when reliable

Public commit record

What the developer wrote

Authored by Salvatore Ingala

78/100 · Adequate
Display total amount of external inputs when reliable

While warning for the presence of external inputs remains necessary
(certain attacks are possible), we can show additional info when
the amount of external inputs is committed to (that is, when the
sighash flag we're signing with does not have ANYONECANPAY, and
therefore the signature commits to all inputs).

In that case, we can show:
- The total amount of external inputs
- The net spend (or receive) from/to the wallet policy, similarly
to the transaction summary shown with certain sighash flags.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
The short version

What changed, and why it matters

This commit changes what information the Ledger Bitcoin app shows on its screen when signing a transaction that includes 'external inputs'—coins the user did not provide and whose amounts the device cannot independently verify. Previously the app only warned that such inputs exist. After this change, when the signature commits to the full set of inputs (i.e., no ANYONECANPAY sighash flag), the app also displays the total value of those external inputs and the net amount the user's wallet is spending or receiving. This is a user-interface improvement intended to reduce confusion, not a fix for a code-execution or theft vulnerability. The underlying security model—external inputs are still 'unverified'—is unchanged.

Recommended action

Treat as a routine UX improvement rather than a security patch. Reviewers may verify that the new rows are only rendered when show_external_inputs_amount is true (closed input set) and that the buffer-size static assertions cover the maximum number of displayed rows. No urgent user action is required.

Security signals we found

01

UI/UX hardening: additional contextual data shown for transactions with unverified external inputs

02

No change to cryptographic checks, sighash validation, or input verification

03

External inputs warning is preserved; new data is displayed only when the input set is closed (no ANYONECANPAY)

04

Static assertion for UI pair buffer size increased to accommodate new rows

05

No memory allocations or buffer writes beyond newly sized fields

Risk score

Why this scored 21/100

Our methodology →
Potential impact 2/30
Exploitability 1/25
Stealth signal 1/15
Affected reach 5/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.