LD
← All projectsLedger

Ledger Bitcoin app

Open-source Bitcoin application running on Ledger devices; the device OS is outside this repository.

BitcoinHardware walletsNormal
Repository coverage

301 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

75security candidates126second-pass queue42AI analyses
59commits · 30 days
82commits · 60 days
231commits · 180 days
301commits · 365 days
Backfill bands
Aug 5 → Feb 670 seen8 candidatesComplete
Feb 6 → Jun 6149 seen21 candidatesComplete
Jun 6 → Jul 623 seen0 candidatesComplete
Jul 6 → Aug 555 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

51/100 average clarity
13Strong · 80–100
76Adequate · 60–79
157Thin · 40–59
55Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Salvatore Ingala1674824155
Ilya Artemov952617145
github-actions[bot]1711046
Mathias BROUSSET1400040
José Luis Landabaso Díaz400067
iartemov-ledger100043
Cerberus Merlin100062
Charles-Edouard de la Vergne100045
Michael Evans100073
Analysis record

Published AI watches

Last scanned 9 minutes ago

Moderate 59 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Type consistency in psbt_parse_rawtx, and some other hardenings

This commit hardens a Bitcoin transaction parser in Ledger's app. It changes some numeric fields to safer types, adds bounds checks on transaction counts and sizes, rejects extra trailing bytes after a transaction, checks a previously-igno…

Integer type narrowing and sentinel change from -1 to SIZE_MAXBounds checks before uint64_t to unsigned int castsReturn value of parser_consolidate_buffers now checked
1af86279by Salvatore Ingala+66−173 files
No security note in commit
Informational 21 AI analysisMessage 78 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Display total amount of external inputs when reliable

This commit changes what information the Ledger Bitcoin app shows on its screen when signing a transaction that includes 'external inputs'—coins the user did not provide and whose amounts the device cannot independently verify. Previously …

UI/UX hardening: additional contextual data shown for transactions with unverified external inputsNo change to cryptographic checks, sighash validation, or input verificationExternal inputs warning is preserved; new data is displayed only when the input set is closed (no ANYONECANPAY)
26f631c5by Salvatore Ingala+126−174 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Trustworthy sign_psbt amount/fee display for non-default sighash: snapshots

This commit only updates test screenshot snapshots for the Ledger Bitcoin app. It does not change any application source code, so it cannot directly fix or introduce a security vulnerability in the shipped app. The snapshots reflect new ex…

No source-code changes in the commitOnly test snapshot images (PNG) are modified or addedCommit title references trustworthy amount/fee display for non-default sighash, suggesting a prior functional change exists elsewhere
086967aeby github-actions[bot]+0−0840 files
No security note in commit
Informational 12 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Trustworthy sign_psbt amount/fee display for non-default sighash: integration tests

This commit only adds and updates automated integration tests for the Ledger Bitcoin app. It does not change the app's actual signing code. The tests verify that the device now shows clearer, more trustworthy on-screen amount and fee infor…

No C/device firmware code changesTest-only commit adjusting UI navigation expectationsNew tests assert that negative fees are rejected for default sighash but allowed/relabeled for ANYONECANPAY sighash
bb6a6aadby Ilya Artemov+175−325 files
No security note in commit
Moderate 59 AI analysisMessage 50 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Trustworthy sign_psbt amount/fee display for non-default sighash: implementation

This commit changes how the Ledger Bitcoin app shows transaction amounts and fees on the device screen when a user signs a transaction that does not use the normal 'sign everything' rule (a so-called non-default sighash). Previously the ap…

UI trust reduction for non-default sighash prevents misleading fee/amount displaySighash classification helpers centralize ANYONECANPAY/NONE/SINGLE semanticsMixed-sighash detection disables coherent amount display
d4525576by Ilya Artemov+451−6612 files
No security note in commit
Informational 19 AI analysisMessage 65 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add support for generating PSBTs for MuSig2 in txmaker

This commit adds test-only helper code for creating Bitcoin transaction fixtures that support newer wallet types (MuSig2 multi-signature and several legacy/wrapped SegWit descriptor forms). It is not a change to the Ledger app firmware its…

No security-relevant signal: change is in test utilities onlyAdds cryptographic helper for MuSig2 key aggregation in test fixturesAdds P2SH/P2SH-P2WPKH/P2SH-P2WSH script generation in test fixtures
13d84acaby Salvatore Ingala+211−112 files
No security note in commit
Informational 15 AI analysisMessage 75 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Link unit tests with speculos implementations of crypto syscalls

This commit is purely about improving the project's automated test setup. It links unit tests to a software simulator (Speculos) so cryptographic code can be tested on a regular computer without a physical Ledger device. It adds tests for …

53a997c6by Salvatore Ingala+747−296 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Get rid of SKIP_FOR_CMOCKA; compile tests with the speculos bridge

This commit is purely a testing infrastructure cleanup. It removes a workaround called SKIP_FOR_CMOCKA that previously hid parts of the code from unit tests, and instead compiles those parts using a more realistic emulator bridge (speculos…

c098c659by Salvatore Ingala+37−8210 files
No security note in commit
Informational 15 AI analysisMessage 70 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Move some duplicated mocking code to headers

This commit is a routine cleanup of the project's unit-test code. It removes duplicate mock implementations of a small helper function called `pic()` from 14 test files and places a single shared version in a mock header. The change only a…

3ac25325by Salvatore Ingala+4−9415 files
No security note in commit
Informational 14 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add utilities to parse serialized PSBTs and mock its maps; added unit tests for extract_bip32_derivation

This commit only adds new unit-test helper code and test cases. It does not change the actual Ledger Bitcoin app that runs on the device, nor does it fix or alter any production security logic. The new files parse PSBT data and mock dispat…

No production code changesNo device-side code changesNo cryptographic or parsing logic changes in the shipped app
e7453297by Salvatore Ingala+890−07 files
No security note in commit
Informational 13 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Improve signing performance in case of several internal keys

This commit is a performance optimization for the Ledger Bitcoin app. It reorders nested loops in two signing-related functions so that the app reads each transaction input's data once and then processes all relevant internal keys, rather …

No security-relevant behavior change identified in commit message or diffRefactoring only: loop reordering with identical helper invocationsPer-input taptree hash now computed once instead of once per key, reducing redundant computation
1d2a4341by Salvatore Ingala+128−891 file
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add account context struct in sign_psbt

This commit is a straightforward internal code cleanup in Ledger's Bitcoin app. It groups several pieces of wallet-policy data into a new 'account context' structure and updates all references accordingly. There is no change to how transac…

b7061e13by Salvatore Ingala+104−823 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Partition sign_psbt.c into smaller submodules

This commit is a large but purely structural code cleanup: it splits the single large sign_psbt.c file into many smaller, focused source files under src/handler/sign_psbt/. The actual logic, function bodies, validation checks, and security…

Large-scale code movement only; no new security checks or relaxed validationsFunctions moved verbatim; logic preservedCopyright year updated from 2025 to 2025, 2026
64c53b1aby Salvatore Ingala+2912−214228 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Partition init_global_state into smaller functions

This commit is a straightforward internal code cleanup: it splits one large function into three smaller, well-documented helper functions and moves one data field into a shared state structure. There is no change to what the code checks, a…

b0b6a1adby Salvatore Ingala+145−922 files
No security note in commit
Informational 18 AI analysisMessage 85 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Generalize return value of sign_psbt in the Rust client

This commit is a routine API update for the Ledger Bitcoin app's Rust client library. It changes what kind of data the library returns when a user signs a Bitcoin transaction (PSBT), so it can also return MuSig2 multi-signature material (p…

dd9e3409by Salvatore Ingala+469−708 files
No security note in commit
Informational 15 AI analysisMessage 55 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add sign_psbt test for MuSig round 1 and 2

This commit only adds new test cases for an existing feature (MuSig multi-signature signing) in the Rust client test suite. It does not change any production code, cryptographic logic, or application behavior. The changes are purely in tes…

a3120ecaby Salvatore Ingala+1103−492 files
No security note in commit
Low 26 AI analysisMessage 80 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add support for "musig()" in the rust client

This commit adds code to the Ledger Bitcoin app's Rust client that pre-processes wallet descriptors containing 'musig(...)' key groups before computing addresses. It implements a small BIP-327/BIP-328 key aggregation so the existing minisc…

New cryptographic key aggregation implementation (BIP-327 KeyAgg)Parsing of untrusted descriptor strings with manual `musig(...)` extractionUse of a hardcoded BIP-328 chain code constant
244d6027by Salvatore Ingala+212−04 files
No security note in commit
Moderate 58 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Guard against sizes that do not fit in an int

This commit adds a safety check in the Ledger Bitcoin app's code that handles BIP32 derivation paths extracted from a PSBT (Partially Signed Bitcoin Transaction). The change prevents a very large, attacker-chosen data length from being sil…

Integer truncation / signedness issue between size_t and intMemory safety hardening in PSBT parsing pathDefensive bounds check added in callback
e4012c72by Salvatore Ingala+10−11 file
No security note in commit
Moderate 58 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Zero output buffer for signatures on errors

This commit fixes a security-sensitive cleanup bug in the Ledger Bitcoin app's signing code. When a cryptographic signing operation failed, the output buffer that would normally hold the signature was not being cleared. That means a partia…

explicit_bzero used to clear sensitive output buffer on error pathpreviously returned -1 without sanitizing out buffercomment explicitly states intent: 'never produce a valid signature on errors'
1509119cby Salvatore Ingala+1−01 file
Vendor flagged security relevance
Moderate 60 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add missing bound check in fpt_der_data_callback

This commit fixes a missing safety check in the Ledger Bitcoin app when reading BIP32 derivation data from a PSBT (Partially Signed Bitcoin Transaction). For non-Taproot transactions, the app was not verifying that the derivation data was …

Missing bounds check on externally supplied length fieldPotential buffer overflow in fixed-size output buffer during PSBT parsingFix adds explicit length validation before memory copy preparation
e92bc067by Salvatore Ingala+7−11 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidateMerge pull request #542 from LedgerHQ/musig-fixesby Salvatore Ingala · 0fec192f · Aug 5, 2026 · 3 filesMessage 68 · AdequateTriage 0Details
Commit message · Salvatore Ingala

Merge pull request #542 from LedgerHQ/musig-fixes

Add some missing error propagation in `musig.c`

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathsigning or wallet pathmerge-commit duplicate discount
Security candidatePropagate crypto_tr_lift_x errors in cpointby Salvatore Ingala · 18647877 · Aug 4, 2026 · 2 filesMessage 45 · ThinTriage 15Details
Commit message · Salvatore Ingala

Propagate crypto_tr_lift_x errors in cpoint

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
Security candidateType consistency in psbt_parse_rawtx, and some other hardeningsby Salvatore Ingala · 1af86279 · Jul 31, 2026 · 3 filesMessage 73 · AdequateModerate 59Details
Commit message · Salvatore Ingala

Type consistency in psbt_parse_rawtx, and some other hardenings

Change key_len and output_index to size_t for consistency with
other APIs, add some extra bounds checks.

Also adds:
- missing return value check on parser_consolidate_buffers
- reject trailing data during parsing
- zero txid_parser_outputs_t before starting parsing

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundarydefensive validationsigning or wallet path
AI analysis · Moderate 59/100

This commit hardens a Bitcoin transaction parser in Ledger's app. It changes some numeric fields to safer types, adds bounds checks on transaction counts and sizes, rejects extra trailing bytes after a transaction, checks a previously-ignored internal buffer operation, and zeroes out result memory before use. These are defensive fixes that could prevent memory corruption, incorrect parsing, or information leakage, but the commit does not describe a specific active exploit.

Security candidateDocument signing behavior with sighash flags, and external inputsby Salvatore Ingala · c4658f0b · Jul 24, 2026 · 2 filesMessage 50 · ThinTriage 0Details
Commit message · Salvatore Ingala

Document signing behavior with sighash flags, and external inputs

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarydocumentation-only discount
Security candidateDisplay total amount of external inputs when reliableby Salvatore Ingala · 26f631c5 · Jul 20, 2026 · 4 filesMessage 78 · AdequateInformational 21Details
Commit message · Salvatore Ingala

Display total amount of external inputs when reliable

While warning for the presence of external inputs remains necessary
(certain attacks are possible), we can show additional info when
the amount of external inputs is committed to (that is, when the
sighash flag we're signing with does not have ANYONECANPAY, and
therefore the signature commits to all inputs).

In that case, we can show:
- The total amount of external inputs
- The net spend (or receive) from/to the wallet policy, similarly
to the transaction summary shown with certain sighash flags.

78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
explicit security languagesigning boundarysigning or wallet path
AI analysis · Informational 21/100

This commit changes what information the Ledger Bitcoin app shows on its screen when signing a transaction that includes 'external inputs'—coins the user did not provide and whose amounts the device cannot independently verify. Previously the app only warned that such inputs exist. After this change, when the signature commits to the full set of inputs (i.e., no ANYONECANPAY sighash flag), the app also displays the total value of those external inputs and the net amount the user's wallet is spending or receiving. This is a user-interface improvement intended to reduce confusion, not a fix for a code-execution or theft vulnerability. The underlying security model—external inputs are still 'unverified'—is unchanged.

Security candidateTrustworthy sign_psbt amount/fee display for non-default sighash: snapshotsby github-actions[bot] · 086967ae · Jul 17, 2026 · 840 filesMessage 50 · ThinInformational 15Details
Commit message · github-actions[bot]

Trustworthy sign_psbt amount/fee display for non-default sighash: snapshots

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit only updates test screenshot snapshots for the Ledger Bitcoin app. It does not change any application source code, so it cannot directly fix or introduce a security vulnerability in the shipped app. The snapshots reflect new expected screen output after a prior code change that altered how amounts and fees are displayed when signing transactions with non-default Bitcoin sighash types.

Security candidateTrustworthy sign_psbt amount/fee display for non-default sighash: integration testsby Ilya Artemov · bb6a6aad · Jul 17, 2026 · 5 filesMessage 60 · AdequateInformational 12Details
Commit message · Ilya Artemov

Trustworthy sign_psbt amount/fee display for non-default sighash: integration tests

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 12/100

This commit only adds and updates automated integration tests for the Ledger Bitcoin app. It does not change the app's actual signing code. The tests verify that the device now shows clearer, more trustworthy on-screen amount and fee information when a transaction uses unusual Bitcoin signature modes (non-default 'sighash' types). Because no production firmware code is modified, there is no direct security vulnerability or fix introduced by this commit itself.

Security candidateTrustworthy sign_psbt amount/fee display for non-default sighash: unit-testsby Ilya Artemov · d44e34dd · Jul 17, 2026 · 1 fileMessage 60 · AdequateTriage 18Details
Commit message · Ilya Artemov

Trustworthy sign_psbt amount/fee display for non-default sighash: unit-tests

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing boundary
Security candidateTrustworthy sign_psbt amount/fee display for non-default sighash: implementationby Ilya Artemov · d4525576 · Jul 17, 2026 · 12 filesMessage 50 · ThinModerate 59Details
Commit message · Ilya Artemov

Trustworthy sign_psbt amount/fee display for non-default sighash: implementation

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 59/100

This commit changes how the Ledger Bitcoin app shows transaction amounts and fees on the device screen when a user signs a transaction that does not use the normal 'sign everything' rule (a so-called non-default sighash). Previously the app might have displayed a fee or total that could actually change later, because some sighash types let other people add inputs or change outputs after the signature. Now the app detects those cases and either shows only the net amount the user is spending/receiving, or shows a warning that amounts cannot be verified. It also adds a 'Signing rule' line so the user knows the transaction is not fully committed.

Security candidateFix slight mismatch in definition of crypto_hash160by Salvatore Ingala · 54587441 · Jun 3, 2026 · 1 fileMessage 50 · ThinTriage 15Details
Commit message · Salvatore Ingala

Fix slight mismatch in definition of crypto_hash160

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
Security candidateRemove initial search for sentinelby Salvatore Ingala · 0ae87d9c · Jun 3, 2026 · 1 fileMessage 68 · AdequateTriage 20Details
Commit message · Salvatore Ingala

Remove initial search for sentinel

It is redundant, it's simpler to just exit when the sentinel is
found.
It was also making clang static analyzer detect a false positive
out of bounds read.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
memory safety
Security candidateAdd support for generating PSBTs for MuSig2 in txmakerby Salvatore Ingala · 13d84aca · Jun 1, 2026 · 2 filesMessage 65 · AdequateInformational 19Details
Commit message · Salvatore Ingala

Add support for generating PSBTs for MuSig2 in txmaker

Also, address the remaining some old TODOs.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 19/100

This commit adds test-only helper code for creating Bitcoin transaction fixtures that support newer wallet types (MuSig2 multi-signature and several legacy/wrapped SegWit descriptor forms). It is not a change to the Ledger app firmware itself, but to Python utilities used in automated tests. There is no obvious security bug introduced, and the commit does not claim to fix a vulnerability.

Security candidateVarious improvements, refactorings and simplifications from PR reviewby Salvatore Ingala · 1e4853f1 · May 29, 2026 · 4 filesMessage 50 · ThinTriage 15Details
Commit message · Salvatore Ingala

Various improvements, refactorings and simplifications from PR review

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
Security candidateLink unit tests with speculos implementations of crypto syscallsby Salvatore Ingala · 53a997c6 · May 29, 2026 · 6 filesMessage 75 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Link unit tests with speculos implementations of crypto syscalls

This allows writing unit tests for code that calls syscalls.
In this commit, tests for bip32_CKDpub are added.

75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
secret or key materialcryptography-sensitive path
AI analysis · Informational 15/100

This commit is purely about improving the project's automated test setup. It links unit tests to a software simulator (Speculos) so cryptographic code can be tested on a regular computer without a physical Ledger device. It adds tests for a Bitcoin key-derivation function and re-enables an existing test file. There is no change to the actual app code that runs on the device, and nothing in the commit suggests a security vulnerability or fix.

Security candidateAdd unit tests for crypto_get_compressed_pubkey_at_pathby Salvatore Ingala · 86fa0b30 · May 29, 2026 · 4 filesMessage 60 · AdequateTriage 15Details
Commit message · Salvatore Ingala

Add unit tests for crypto_get_compressed_pubkey_at_path

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
Security candidateAdd unit tests for crypto_ecdsa_sign_sha256_hash_with_keyby Salvatore Ingala · 96a9203d · May 29, 2026 · 2 filesMessage 60 · AdequateTriage 15Details
Commit message · Salvatore Ingala

Add unit tests for crypto_ecdsa_sign_sha256_hash_with_key

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
Security candidateUnit tests for the crypto_tr_* taproot helpersby Salvatore Ingala · cc9ea60d · May 29, 2026 · 2 filesMessage 55 · ThinTriage 15Details
Commit message · Salvatore Ingala

Unit tests for the crypto_tr_* taproot helpers

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
Security candidateAdd unit tests for crypto_{get_key_fingerprint,master_key_fingerprint,derive_symmetric_key_slip21} and get_extended_pubkey_at_pathby Salvatore Ingala · 65279632 · May 29, 2026 · 1 fileMessage 60 · AdequateTriage 15Details
Commit message · Salvatore Ingala

Add unit tests for crypto_{get_key_fingerprint,master_key_fingerprint,derive_symmetric_key_slip21} and get_extended_pubkey_at_path

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
Security candidateGet rid of SKIP_FOR_CMOCKA; compile tests with the speculos bridgeby Salvatore Ingala · c098c659 · May 29, 2026 · 10 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Get rid of SKIP_FOR_CMOCKA; compile tests with the speculos bridge

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Informational 15/100

This commit is purely a testing infrastructure cleanup. It removes a workaround called SKIP_FOR_CMOCKA that previously hid parts of the code from unit tests, and instead compiles those parts using a more realistic emulator bridge (speculos). No user-facing behavior of the Bitcoin app changes, and no security bug is fixed or introduced in the diff.

Security candidateAdd minimal utility functions to work with serialized xpub in unit testsby Salvatore Ingala · 31a302d2 · May 29, 2026 · 4 filesMessage 75 · AdequateTriage 15Details
Commit message · Salvatore Ingala

Add minimal utility functions to work with serialized xpub in unit tests

It is much cleaner than encoding in hex.

75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
cryptography-sensitive path
Security candidateDelete mock_include, rely on the speculos_bridge for all testsby Salvatore Ingala · 6f7b4472 · May 29, 2026 · 28 filesMessage 60 · AdequateTriage 15Details
Commit message · Salvatore Ingala

Delete mock_include, rely on the speculos_bridge for all tests

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
Security candidateAdd unit tests for crypto_ripemd160, crypto_hash160, crypto_get_checksumby Salvatore Ingala · af900978 · May 29, 2026 · 2 filesMessage 60 · AdequateTriage 15Details
Commit message · Salvatore Ingala

Add unit tests for crypto_ripemd160, crypto_hash160, crypto_get_checksum

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
Security candidateAdditional unit testsby Salvatore Ingala · e130db4d · May 19, 2026 · 6 filesMessage 73 · AdequateTriage 15Details
Commit message · Salvatore Ingala

Additional unit tests

This reaches 100% coverage, except a few lines that can't be
covered (either gcov artifacts, or non-reachable code because of
defense-in-depth checks).

73/100 · AdequateMessage clarity
✓ Subject identifies a change✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
cryptography-sensitive path
Security candidateNits from reviewby Salvatore Ingala · 9e23b56d · May 19, 2026 · 6 filesMessage 28 · OpaqueTriage 15Details
Commit message · Salvatore Ingala

Nits from review

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
cryptography-sensitive path
Security candidateAdd initial mock for the dispatcher, and tests for get_preimageby Salvatore Ingala · 5ac1ec68 · May 19, 2026 · 8 filesMessage 60 · AdequateTriage 15Details
Commit message · Salvatore Ingala

Add initial mock for the dispatcher, and tests for get_preimage

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive path